Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14327#discussion_r71992303
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
---
@@ -422,6 +422,32 @@ class DatasetSuite extends QueryTest
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14326#discussion_r71992412
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/RobustRegression.scala ---
@@ -0,0 +1,466 @@
+/*
+ * Licensed to the Apache
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14326#discussion_r71992494
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/RobustRegression.scala ---
@@ -0,0 +1,466 @@
+/*
+ * Licensed to the Apache
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14322#discussion_r71992661
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala
---
@@ -135,9 +135,17 @@ private[sql] object
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14326#discussion_r71992352
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/RobustRegression.scala ---
@@ -0,0 +1,466 @@
+/*
+ * Licensed to the Apache
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14326#discussion_r71992548
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/RobustRegression.scala ---
@@ -0,0 +1,466 @@
+/*
+ * Licensed to the Apache
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14326#discussion_r71992373
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/RobustRegression.scala ---
@@ -0,0 +1,466 @@
+/*
+ * Licensed to the Apache
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14326#discussion_r71992526
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/RobustRegression.scala ---
@@ -0,0 +1,466 @@
+/*
+ * Licensed to the Apache
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14326#discussion_r71992524
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/RobustRegression.scala ---
@@ -0,0 +1,466 @@
+/*
+ * Licensed to the Apache
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14326#discussion_r71992598
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/RobustRegression.scala ---
@@ -0,0 +1,466 @@
+/*
+ * Licensed to the Apache
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14285#discussion_r71776459
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -167,6 +168,21 @@ abstract class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14304#discussion_r71780859
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetEncodingSuite.scala
---
@@ -78,4 +78,29 @@ class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14284#discussion_r71781038
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLWindowFunctionSuite.scala
---
@@ -357,14 +356,59 @@ class SQLWindowFunctionSuite
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14304#discussion_r71844762
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetEncodingSuite.scala
---
@@ -78,4 +78,30 @@ class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14304#discussion_r71844632
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetEncodingSuite.scala
---
@@ -78,4 +78,30 @@ class
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/14315
[HOTFIX] Fix annotation argument needs to be a constant
## What changes were proposed in this pull request?
Fix for compilation error:
```
/Users/jacek/dev/oss/spark
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/14315
I'm on Java 8. I bet you are not. True?
Also, I remembered how to fix it since this kind of error happened in the
past few times.
---
If your project is set up for it, you can
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/14315
/cc @cloud-fan @techaddict
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14292#discussion_r72137376
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -269,19 +273,11 @@ class StreamExecution
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14414#discussion_r73033311
--- Diff: docs/running-on-mesos.md ---
@@ -468,6 +468,17 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14414#discussion_r73032355
--- Diff:
core/src/main/scala/org/apache/spark/deploy/mesos/ui/MesosClusterPage.scala ---
@@ -28,10 +28,17 @@ import
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14414#discussion_r73032820
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -364,7 +377,12 @@ private[spark] class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14410#discussion_r73035235
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala
---
@@ -449,6 +449,22 @@ class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14410#discussion_r73035297
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -1457,6 +1457,59 @@ class SQLQuerySuite extends
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14414#discussion_r73032912
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -152,8 +152,13 @@ private
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14414#discussion_r73032952
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -152,8 +152,13 @@ private
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14414#discussion_r73033008
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -152,8 +152,13 @@ private
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14410#discussion_r73034796
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -236,6 +236,11 @@ case class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14410#discussion_r73034863
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -236,6 +236,11 @@ case class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14414#discussion_r73032511
--- Diff:
core/src/main/scala/org/apache/spark/deploy/mesos/ui/MesosClusterPage.scala ---
@@ -28,10 +28,17 @@ import
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14450#discussion_r73511032
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java
---
@@ -204,7 +205,8
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14450#discussion_r73510962
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java
---
@@ -140,7 +140,8
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14435#discussion_r7845
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -495,6 +573,92 @@ case class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14435#discussion_r73334242
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -739,6 +931,15 @@ case class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r73337339
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -218,9 +221,44 @@ class AnalysisSuite
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r73337483
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -218,9 +221,44 @@ class AnalysisSuite
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14451#discussion_r73339896
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
@@ -228,6 +228,7 @@ class DataFrameReader private[sql](sparkSession
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/14561
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/14636
The JIRA issue (https://issues.apache.org/jira/browse/SPARK-17053) is
closed as Won't Fix. Should the PR be closed too?
---
If your project is set up for it, you can reply to this email
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14576#discussion_r74706380
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/ReduceAggregator.scala
---
@@ -0,0 +1,79 @@
+/*
+ * Licensed
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/14561
Finally someone took the responsibility and is clearing that important and
critical path in Spark Core. Whenever I see the code, I feel what @lshmouse
felt -- it has to be refactored
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14637#discussion_r74706517
--- Diff: mesos/pom.xml ---
@@ -0,0 +1,167 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLS
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14637#discussion_r74706568
--- Diff:
mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterManager.scala
---
@@ -0,0 +1,61 @@
+/*
+ * Licensed
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14637#discussion_r74706502
--- Diff: mesos/pom.xml ---
@@ -0,0 +1,167 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLS
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14637#discussion_r74706522
--- Diff: mesos/pom.xml ---
@@ -0,0 +1,167 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLS
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14637#discussion_r74706494
--- Diff: mesos/pom.xml ---
@@ -0,0 +1,167 @@
+
+
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14637#discussion_r74706552
--- Diff:
mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterManager.scala
---
@@ -0,0 +1,61 @@
+/*
+ * Licensed
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/14557
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14524#discussion_r74680486
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala
---
@@ -67,7 +67,7 @@ private[shared] object
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14524#discussion_r74688310
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala
---
@@ -67,7 +67,7 @@ private[shared] object
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14557#discussion_r74688557
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -798,6 +798,19 @@ private[spark] class TaskSetManager
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14557#discussion_r74688576
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -798,6 +798,19 @@ private[spark] class TaskSetManager
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14557#discussion_r74688550
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -798,6 +798,19 @@ private[spark] class TaskSetManager
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14207#discussion_r71083334
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala ---
@@ -351,6 +353,44 @@ class CatalogImpl(sparkSession
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14207#discussion_r71083304
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -487,6 +487,10 @@ object DDLUtils
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14122#discussion_r71083220
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -327,6 +327,11 @@ class LinearRegression @Since("
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14217#discussion_r71072773
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetIOSuite.scala
---
@@ -169,6 +169,19 @@ class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14210#discussion_r71072842
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1264,6 +1265,29 @@ class DDLSuite extends QueryTest
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14210#discussion_r71072854
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/CreateTableAsSelectSuite.scala
---
@@ -212,7 +213,23 @@ class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14210#discussion_r71072892
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1264,6 +1265,29 @@ class DDLSuite extends QueryTest
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14210#discussion_r71072862
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/CreateTableAsSelectSuite.scala
---
@@ -199,7 +200,7 @@ class CreateTableAsSelectSuite
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14034#discussion_r69528969
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/StatisticsSuite.scala ---
@@ -31,4 +33,46 @@ class StatisticsSuite extends QueryTest
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14047#discussion_r69527187
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -391,6 +391,29 @@ class HiveDDLSuite
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13981#discussion_r69631781
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/DecisionTreeRegressorSuite.scala
---
@@ -96,6 +97,25 @@ class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14087#discussion_r69984805
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamReader.scala
---
@@ -281,6 +281,31 @@ final class DataStreamReader
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14087#discussion_r69984678
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamReader.scala
---
@@ -281,6 +281,31 @@ final class DataStreamReader
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14080#discussion_r69981791
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java
---
@@ -143,4 +179,26 @@ private
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14087#discussion_r69985100
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamReader.scala
---
@@ -281,6 +281,31 @@ final class DataStreamReader
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14087#discussion_r69985379
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSourceSuite.scala
---
@@ -331,6 +331,24 @@ class FileStreamSourceSuite
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14083#discussion_r69982767
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -165,111 +169,99 @@ abstract class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14087#discussion_r69984584
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamReader.scala
---
@@ -281,6 +281,31 @@ final class DataStreamReader
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13526#discussion_r69986420
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/KeyValueGroupedDataset.scala ---
@@ -65,6 +65,46 @@ class KeyValueGroupedDataset[K, V] private
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14087#discussion_r69985212
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamReader.scala
---
@@ -281,6 +281,31 @@ final class DataStreamReader
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14087#discussion_r69985195
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamReader.scala
---
@@ -281,6 +281,31 @@ final class DataStreamReader
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13526#discussion_r69986532
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/KeyValueGroupedDataset.scala ---
@@ -65,6 +65,46 @@ class KeyValueGroupedDataset[K, V] private
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13526#discussion_r69986479
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/KeyValueGroupedDataset.scala ---
@@ -65,6 +65,46 @@ class KeyValueGroupedDataset[K, V] private
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13526#discussion_r69986596
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
---
@@ -312,6 +312,17 @@ class DatasetSuite extends QueryTest
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13526#discussion_r69986179
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/object.scala
---
@@ -175,6 +175,17 @@ object AppendColumns
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13526#discussion_r69986245
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/KeyValueGroupedDataset.scala ---
@@ -65,6 +65,46 @@ class KeyValueGroupedDataset[K, V] private
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14047#discussion_r69487586
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -391,6 +391,29 @@ class HiveDDLSuite
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14034#discussion_r69488260
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -251,6 +251,22 @@ trait CheckAnalysis
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13981#discussion_r69703134
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/DecisionTreeRegressorSuite.scala
---
@@ -96,6 +97,25 @@ class
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/14533
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14414#discussion_r73032190
--- Diff:
core/src/main/scala/org/apache/spark/deploy/mesos/ui/MesosClusterPage.scala ---
@@ -28,10 +28,17 @@ import
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14410#discussion_r73051607
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -1457,6 +1457,59 @@ class SQLQuerySuite extends
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14292#discussion_r71870509
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala
---
@@ -91,18 +92,30 @@ class HDFSMetadataLog[T
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14292#discussion_r71870459
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala
---
@@ -91,18 +92,30 @@ class HDFSMetadataLog[T
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14292#discussion_r71870635
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala
---
@@ -91,18 +92,30 @@ class HDFSMetadataLog[T
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14292#discussion_r71871037
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -269,19 +273,11 @@ class StreamExecution
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14292#discussion_r71871337
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestUtils.scala ---
@@ -247,6 +248,46 @@ private[sql] trait SQLTestUtils
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14292#discussion_r71871490
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestUtils.scala ---
@@ -247,6 +248,46 @@ private[sql] trait SQLTestUtils
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14295#discussion_r71871696
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Last.scala
---
@@ -42,6 +42,17 @@ case class Last(child
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14295#discussion_r71871902
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Last.scala
---
@@ -42,6 +42,17 @@ case class Last(child
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14313#discussion_r71977310
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
---
@@ -322,46 +322,134 @@ private[sql] class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14313#discussion_r71977337
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
---
@@ -322,46 +322,134 @@ private[sql] class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14313#discussion_r71977329
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
---
@@ -322,46 +322,134 @@ private[sql] class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14313#discussion_r71977368
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
---
@@ -407,84 +495,8 @@ private[sql] class JDBCRDD
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14313#discussion_r71977344
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
---
@@ -322,46 +322,134 @@ private[sql] class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14435#discussion_r73332522
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -53,6 +53,40 @@ case class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14435#discussion_r73332988
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -99,6 +133,12 @@ case class
201 - 300 of 589 matches
Mail list logo
