Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22305#discussion_r240092271
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/WindowInPandasExec.scala
---
@@ -144,24 +282,107 @@ case class WindowInPandasExec
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/23245
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22305#discussion_r239666242
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/WindowInPandasExec.scala
---
@@ -144,24 +282,107 @@ case class WindowInPandasExec
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/23245
[SPARK-26060][SQL][FOLLOW-UP] Rename the config name.
## What changes were proposed in this pull request?
This is a follow-up of #23031 to rename the config name.
The `execution
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/23245
cc @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22305#discussion_r239312302
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/WindowInPandasExec.scala
---
@@ -144,24 +282,107 @@ case class WindowInPandasExec
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22305#discussion_r239307965
--- Diff: python/pyspark/sql/tests/test_pandas_udf_window.py ---
@@ -231,12 +266,10 @@ def test_array_type(self):
self.assertEquals(result1
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22305#discussion_r239307779
--- Diff: python/pyspark/sql/tests/test_pandas_udf_window.py ---
@@ -87,8 +96,34 @@ def ordered_window(self):
def unpartitioned_window(self
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22305#discussion_r239308506
--- Diff: python/pyspark/sql/tests/test_pandas_udf_window.py ---
@@ -245,11 +278,101 @@ def test_invalid_args(self):
foo_udf
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22305#discussion_r239307483
--- Diff: python/pyspark/sql/tests/test_pandas_udf_window.py ---
@@ -44,9 +44,18 @@ def python_plus_one(self):
@property
def
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22512#discussion_r238146834
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/InterpretedMutableProjection.scala
---
@@ -64,7 +85,7 @@ class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23176#discussion_r237826533
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/PredicateSuite.scala
---
@@ -293,6 +293,54 @@ class PredicateSuite extends
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/23187
[SPARK-26211][SQL][FOLLOW-UP] Combine test cases for `In` and `InSet`.
## What changes were proposed in this pull request?
This is a follow pr of #23176.
`In` and `InSet
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/23187
cc @gatorsmile @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23176#discussion_r237771176
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/PredicateSuite.scala
---
@@ -293,6 +293,54 @@ class PredicateSuite extends
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/23031
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/23031
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/23031
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23176#discussion_r237400321
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -367,11 +367,29 @@ case class InSet(child
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23176#discussion_r237399670
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -367,11 +367,29 @@ case class InSet(child
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/23176
cc @cloud-fan @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/23176
[SPARK-26211][SQL] Fix InSet for binary, and struct and array with null.
## What changes were proposed in this pull request?
Currently `InSet` doesn't work properly for binary type
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/23031
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23031#discussion_r237071928
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/RuntimeConfig.scala
---
@@ -154,5 +154,9 @@ class RuntimeConfig private[sql](sqlConf: SQLConf = new
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23124#discussion_r236973308
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayBasedMapData.scala
---
@@ -19,6 +19,12 @@ package
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23124#discussion_r236955791
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayBasedMapBuilder.scala
---
@@ -0,0 +1,118 @@
+/*
+ * Licensed
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23124#discussion_r236958252
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/ArrayBasedMapBuilderSuite.scala
---
@@ -0,0 +1,91 @@
+/*
+ * Licensed
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/23101
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/23101
also cc @wangyum for the owner of
[SPARK-25330](https://issues.apache.org/jira/browse/SPARK-25330).
---
-
To unsubscribe, e-mail
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/23101
cc @srowen
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/23101
I guess we need to update `dev/deps/spark-deps-hadoop-2.7` file as well.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/23082
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/23082
cc @cloud-fan @gatorsmile @dongjoon-hyun
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/23082
[SPARK-26112][SQL] Update since versions of new built-in functions.
## What changes were proposed in this pull request?
The following 5 functions were removed from branch-2.4
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/23045
LGTM.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23045#discussion_r234502854
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -521,13 +521,18 @@ case class MapEntries
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23045#discussion_r234481249
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -521,13 +521,18 @@ case class MapEntries
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23046#discussion_r234073072
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala
---
@@ -280,7 +280,7 @@ object ShuffleExchangeExec
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/23046
cc @jiangxb1987 @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/23046
[SPARK-23207][SQL][FOLLOW-UP] Use `SQLConf.get.enableRadixSort` instead of
`SparkEnv.get.conf.get(SQLConf.RADIX_SORT_ENABLED)`.
## What changes were proposed in this pull request
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/23031
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/23031
@vanzin Thanks for letting me know it and that's really good to know.
I'll update this to use it.
---
-
To unsubscribe, e
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/23031
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/23031
[SPARK-26060][CORE][SQL] Track SparkConf entries and make SET command
reject such entries.
## What changes were proposed in this pull request?
Currently the `SET` command works without any
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22200#discussion_r232608144
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -154,6 +154,15 @@ object Cast {
fromPrecedence
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22969#discussion_r231783323
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -787,7 +789,7 @@ case class HashAggregateExec
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22969
cc @sitalkedia @cloud-fan @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/22969
[SPARK-22827][SQL][FOLLOW-UP] Throw `SparkOutOfMemoryError` in
`HashAggregateExec`, too.
## What changes were proposed in this pull request?
This is a follow-up pr of #20014 which
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22305#discussion_r231408205
--- Diff: python/pyspark/sql/tests.py ---
@@ -6323,6 +6333,33 @@ def ordered_window(self):
def unpartitioned_window(self):
return
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22305#discussion_r231420974
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/WindowInPandasExec.scala
---
@@ -73,68 +118,147 @@ case class WindowInPandasExec
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22305#discussion_r231427886
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/WindowInPandasExec.scala
---
@@ -73,68 +118,147 @@ case class WindowInPandasExec
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22305#discussion_r231407486
--- Diff: python/pyspark/sql/tests.py ---
@@ -6323,6 +6333,33 @@ def ordered_window(self):
def unpartitioned_window(self):
return
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22305#discussion_r231429605
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/WindowInPandasExec.scala
---
@@ -73,68 +118,147 @@ case class WindowInPandasExec
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22305#discussion_r231416643
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/WindowInPandasExec.scala
---
@@ -27,17 +27,62 @@ import
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22305#discussion_r231413246
--- Diff: python/pyspark/worker.py ---
@@ -154,6 +154,47 @@ def wrapped(*series):
return lambda *a: (wrapped(*a), arrow_return_type
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22305
I'll do a review too hopefully this week. Sorry for the delay.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22928
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22913#discussion_r230635196
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ArrowColumnVector.java
---
@@ -414,6 +416,21 @@ final int getInt(int rowId
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/22942
[SPARK-25884][SQL][FOLLOW-UP] Add sample.json back.
## What changes were proposed in this pull request?
This is a follow-up pr of #22892 which moved `sample.json` from hive module
to sql
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22942
cc @srowen @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22892
Seems like we still need `sample.json` in hive module. I'll submit a
follow-up pr.
---
-
To unsubscribe, e-mail: reviews
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22913#discussion_r230628333
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowUtils.scala
---
@@ -71,6 +71,7 @@ object ArrowUtils {
case d
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22928
cc @jiangxb1987 @cloud-fan @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/22928
[SPARK-25926][CORE] Move config entries in core module to internal.config.
## What changes were proposed in this pull request?
Currently definitions of config entries in `core` module
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22892#discussion_r229737749
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveShowCreateTableSuite.scala
---
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22892#discussion_r229278709
--- Diff: sql/core/src/test/resources/sample.json ---
@@ -0,0 +1,2 @@
+{"a" : "2" ,"b" : "blah", "c_!@(3)&
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/22892
[SPARK-25884][SQL] Add TBLPROPERTIES and COMMENT, and use LOCATION when
SHOW CREATE TABLE.
## What changes were proposed in this pull request?
When `SHOW CREATE TABLE` for Datasource
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22892
cc @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22816
Thanks! merging to master/2.4/2.3.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22816
LGTM.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22466#discussion_r226624218
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -207,6 +207,14 @@ class SessionCatalog
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22466#discussion_r226536626
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -840,12 +840,19 @@ abstract class DDLSuite extends QueryTest
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22762#discussion_r226266575
--- Diff: python/pyspark/sql/tests.py ---
@@ -225,6 +225,55 @@ def sql_conf(self, pairs):
else
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22466
Btw, what if `create database if not exists ...`? Seems like an exception
will be thrown if the table exists even if we specify `if not exists
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22762
cc @HyukjinKwon
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22762
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22466#discussion_r226245229
--- Diff: python/pyspark/sql/tests.py ---
@@ -2993,6 +2990,7 @@ def test_current_database(self):
AnalysisException
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/22762
[SPARK-25763][SQL][PYSPARK][TEST] Use more `@contextmanager` to ensure
clean-up each test.
## What changes were proposed in this pull request?
Currently each test in `SQLTest` in PySpark
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22466#discussion_r226236226
--- Diff: python/pyspark/sql/tests.py ---
@@ -2993,6 +2990,7 @@ def test_current_database(self):
AnalysisException
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/21990
LGTM.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21990#discussion_r225811960
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -1136,4 +1121,27 @@ object SparkSession extends Logging
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22646#discussion_r225807075
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -1115,9 +1126,38 @@ object SQLContext
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22646#discussion_r225807045
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -1115,9 +1126,38 @@ object SQLContext
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22646#discussion_r225806457
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -1115,9 +1126,38 @@ object SQLContext
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21990#discussion_r225762148
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -1136,4 +1121,27 @@ object SparkSession extends Logging
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21990#discussion_r225439067
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -1136,4 +1121,27 @@ object SparkSession extends Logging
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22724#discussion_r225389273
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
---
@@ -196,6 +197,48 @@ object Literal {
case
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22724#discussion_r225387436
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
---
@@ -196,6 +197,48 @@ object Literal {
case
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22724#discussion_r225194050
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
---
@@ -196,6 +197,31 @@ object Literal {
case
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21990#discussion_r225077270
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -1136,4 +1121,27 @@ object SparkSession extends Logging
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22646#discussion_r224671775
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -1115,9 +1126,38 @@ object SQLContext
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22466#discussion_r224667371
--- Diff: python/pyspark/sql/tests.py ---
@@ -2993,6 +2990,7 @@ def test_current_database(self):
AnalysisException
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22466#discussion_r224666263
--- Diff: python/pyspark/sql/tests.py ---
@@ -350,9 +350,6 @@ def test_sqlcontext_reuses_sparksession(self):
def tearDown(self):
--- End diff
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22309#discussion_r224318955
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/ScalaReflectionSuite.scala
---
@@ -108,6 +108,16 @@ object TestingUDT
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22545#discussion_r223953269
--- Diff: python/pyspark/sql/session.py ---
@@ -156,7 +156,7 @@ def getOrCreate(self):
default.
>&g
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/22682
[SPARK-20946][SPARK-25525][SQL][FOLLOW-UP] Update the migration guide.
## What changes were proposed in this pull request?
This is a follow-up pr of #18536 and #22545 to update
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22682
cc @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22527
Seems like there is a merge commit in apache git
https://git-wip-us.apache.org/repos/asf?p=spark.git, but not in GitHub yet
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22527
Sorry, the merge script failed. Let me try again a while later.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22527
I'd merge this not to block the following prs to support array/list and map
of beans.
---
-
To unsubscribe, e-mail: reviews
1 - 100 of 2567 matches
Mail list logo
