[GitHub] spark pull request #13517: [SPARK-14839][SQL] Support for other types as opt...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13517#discussion_r69385174 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -45,11 +45,11 @@ statement | ALTER DATABASE

[GitHub] spark pull request #13517: [SPARK-14839][SQL] Support for other types as opt...

Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13517#discussion_r69380919 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -45,11 +45,11 @@ statement | ALTER DATABASE

[GitHub] spark pull request #13517: [SPARK-14839][SQL] Support for other types as opt...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13517#discussion_r69377675 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -45,11 +45,11 @@ statement | ALTER DATABASE

[GitHub] spark pull request #13517: [SPARK-14839][SQL] Support for other types as opt...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13517#discussion_r68871740 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -45,11 +45,11 @@ statement | ALTER DATABASE

[GitHub] spark pull request #13517: [SPARK-14839][SQL] Support for other types as opt...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13517#discussion_r68869270 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -45,11 +45,11 @@ statement | ALTER DATABASE

[GitHub] spark pull request #13517: [SPARK-14839][SQL] Support for other types as opt...

Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13517#discussion_r68699390 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -435,6 +434,37 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] spark pull request #13517: [SPARK-14839][SQL] Support for other types as opt...

Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13517#discussion_r68699131 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -45,11 +45,11 @@ statement | ALTER DATABASE

[GitHub] spark pull request #13517: [SPARK-14839][SQL] Support for other types as opt...

Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13517#discussion_r68698738 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -252,6 +252,21 @@ tablePropertyKey | STRING

[GitHub] spark pull request #13517: [SPARK-14839][SQL] Support for other types as opt...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13517#discussion_r65991481 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -435,6 +434,37 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] spark pull request #13517: [SPARK-14839][SQL] Support for other types as opt...

Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/13517#discussion_r65975446 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -435,6 +434,37 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] spark pull request #13517: [SPARK-14839][SQL] Support for other types as opt...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13517#discussion_r65835938 --- Diff: python/pyspark/sql/readwriter.py --- @@ -180,6 +180,9 @@ def json(self, path, schema=None, primitivesAsString=None, prefersDecimal=None,

[GitHub] spark pull request #13517: [SPARK-14839][SQL] Support for other types as opt...

Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13517#discussion_r65834648 --- Diff: python/pyspark/sql/readwriter.py --- @@ -180,6 +180,9 @@ def json(self, path, schema=None, primitivesAsString=None, prefersDecimal=None,

[GitHub] spark pull request #13517: [SPARK-14839][SQL] Support for other types as opt...

GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/13517 [SPARK-14839][SQL] Support for other types as option in OPTIONS clause ## What changes were proposed in this pull request? Currently, Scala API supports to take options with the types,