Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19290#discussion_r140651399
--- Diff: R/pkg/R/column.R ---
@@ -238,8 +238,10 @@ setMethod("between", signature(x = "Column"),
#' @param x a Column.
#' @param dataType a
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19290#discussion_r140651387
--- Diff: dev/lint-r.R ---
@@ -24,10 +24,16 @@ if (! library(SparkR, lib.loc = LOCAL_LIB_LOC,
logical.return = TRUE)) {
stop("You should install
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19290#discussion_r140643692
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2650,8 +2650,9 @@ setMethod("merge",
#' @param suffix a suffix for the column name
#' @return list of
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19290#discussion_r140244036
--- Diff: dev/lint-r.R ---
@@ -28,6 +28,7 @@ if (! library(SparkR, lib.loc = LOCAL_LIB_LOC,
logical.return = TRUE)) {
# NOTE: The CRAN's version
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19290#discussion_r140242203
--- Diff: dev/lint-r.R ---
@@ -28,6 +28,7 @@ if (! library(SparkR, lib.loc = LOCAL_LIB_LOC,
logical.return = TRUE)) {
# NOTE: The CRAN's version is too
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19290#discussion_r140238274
--- Diff: dev/lint-r.R ---
@@ -28,6 +28,7 @@ if (! library(SparkR, lib.loc = LOCAL_LIB_LOC,
logical.return = TRUE)) {
# NOTE: The CRAN's version
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19290#discussion_r140151179
--- Diff: dev/lint-r.R ---
@@ -28,6 +28,7 @@ if (! library(SparkR, lib.loc = LOCAL_LIB_LOC,
logical.return = TRUE)) {
# NOTE: The CRAN's version
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19290#discussion_r140150499
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2649,15 +2651,15 @@ setMethod("merge",
#' @return list of columns
#'
#' @note
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19290#discussion_r140150229
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2594,12 +2596,12 @@ setMethod("merge",
} else {
# if by or both by.x and by.y
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19290#discussion_r140150600
--- Diff: R/pkg/R/context.R ---
@@ -329,7 +329,7 @@ spark.addFile <- function(path, recursive = FALSE) {
#' spark.getSparkFilesRootDirectory()
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19290#discussion_r139919715
--- Diff: R/pkg/R/mllib_tree.R ---
@@ -132,10 +132,10 @@ print.summary.decisionTree <- function(x) {
#' Gradient Boosted Tree model, \code{predict}
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19290#discussion_r139919722
--- Diff: R/pkg/R/mllib_tree.R ---
@@ -567,10 +569,10 @@ setMethod("write.ml", signature(object =
"RandomForestClassificationModel", path
#'
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19290#discussion_r139919377
--- Diff: R/pkg/R/context.R ---
@@ -329,7 +329,7 @@ spark.addFile <- function(path, recursive = FALSE) {
#' spark.getSparkFilesRootDirectory()
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19290#discussion_r139919190
--- Diff: R/pkg/R/column.R ---
@@ -238,8 +238,8 @@ setMethod("between", signature(x = "Column"),
#' @param x a Column.
#' @param dataType a
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19290#discussion_r139919707
--- Diff: R/pkg/R/mllib_tree.R ---
@@ -352,10 +353,10 @@ setMethod("write.ml", signature(object =
"GBTClassificationModel", path = "chara
#'
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19290#discussion_r139919889
--- Diff: dev/lint-r.R ---
@@ -28,6 +28,7 @@ if (! library(SparkR, lib.loc = LOCAL_LIB_LOC,
logical.return = TRUE)) {
# NOTE: The CRAN's version
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19290#discussion_r139919103
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2649,15 +2651,15 @@ setMethod("merge",
#' @return list of columns
#'
#' @note
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19290#discussion_r139918553
--- Diff: R/pkg/.lintr ---
@@ -1,2 +1,2 @@
-linters: with_defaults(line_length_linter(100), multiple_dots_linter =
NULL, camel_case_linter = NULL,
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/19290
[WIP][SPARK-22063][R] Upgrades lintr to latest commit sha1 ID
## What changes were proposed in this pull request?
Currently, we set lintr to `jimhester/lintr@a769c0b` (see
19 matches
Mail list logo
