Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-15 Thread via GitHub
panbingkun commented on PR #37588: URL: https://github.com/apache/spark/pull/37588#issuecomment-1813824544 > thanks, merging to master! Thank you again for your great help! ❤️❤️❤️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-15 Thread via GitHub
cloud-fan closed pull request #37588: [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 URL: https://github.com/apache/spark/pull/37588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-15 Thread via GitHub
cloud-fan commented on PR #37588: URL: https://github.com/apache/spark/pull/37588#issuecomment-1813802035 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-15 Thread via GitHub
panbingkun commented on PR #37588: URL: https://github.com/apache/spark/pull/37588#issuecomment-1813555489 @cloud-fan If you have time, could you please take a look at this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-12 Thread via GitHub
panbingkun commented on PR #37588: URL: https://github.com/apache/spark/pull/37588#issuecomment-1807121343 > unfortunately this has conflicts now... Done, I have resolved these conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-12 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1390406012 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExtendedExec.scala: ## @@ -0,0 +1,192 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-12 Thread via GitHub
cloud-fan commented on PR #37588: URL: https://github.com/apache/spark/pull/37588#issuecomment-1807069942 unfortunately this has conflicts now... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-10 Thread via GitHub
beliefer commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1390118872 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExtendedExec.scala: ## @@ -0,0 +1,192 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-10 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1389120888 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExec.scala: ## @@ -33,17 +41,36 @@ case class ShowTablesExec( output:

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-06 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1384419375 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala: ## @@ -1090,6 +1090,26 @@ class SessionCatalog( dbViews ++

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-06 Thread via GitHub
beliefer commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1383248874 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala: ## @@ -1090,6 +1090,26 @@ class SessionCatalog( dbViews ++

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-06 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1383227023 ## sql/core/src/test/scala/org/apache/spark/sql/execution/command/ShowTablesSuiteBase.scala: ## @@ -126,4 +158,258 @@ trait ShowTablesSuiteBase extends QueryTest

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-06 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1383222640 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExtendedExec.scala: ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-05 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1382875485 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExtendedExec.scala: ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-05 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1382833311 ## dev/appveyor-install-dependencies.ps1: ## @@ -27,11 +27,13 @@ Function InstallR { $urlPath = "" $latestVer = $(ConvertFrom-JSON $(Invoke-WebRequest

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-05 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1382830431 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExtendedExec.scala: ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-05 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1382829435 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -4055,19 +4055,34 @@ class AstBuilder extends DataTypeAstBuilder with

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-05 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1382828588 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala: ## @@ -1090,6 +1090,28 @@ class SessionCatalog( dbViews ++

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-05 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1382827489 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -4055,19 +4055,34 @@ class AstBuilder extends DataTypeAstBuilder with

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-05 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1382826928 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala: ## @@ -1090,6 +1090,28 @@ class SessionCatalog( dbViews ++

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-05 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1382826777 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala: ## @@ -1090,6 +1090,28 @@ class SessionCatalog( dbViews ++

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-03 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1381687816 ## sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowTablesSuite.scala: ## @@ -165,4 +154,63 @@ class ShowTablesSuite extends ShowTablesSuiteBase

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-03 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1381686442 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExtendedExec.scala: ## @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-03 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1381660558 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExtendedExec.scala: ## @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-03 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1381660916 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExtendedExec.scala: ## @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-03 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1381660206 ## sql/core/src/test/scala/org/apache/spark/sql/execution/command/ShowTablesSuiteBase.scala: ## @@ -40,6 +40,38 @@ trait ShowTablesSuiteBase extends QueryTest with

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-03 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1381659193 ## sql/core/src/test/scala/org/apache/spark/sql/execution/command/ShowTablesSuiteBase.scala: ## @@ -40,6 +40,38 @@ trait ShowTablesSuiteBase extends QueryTest with

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-03 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1381658801 ## sql/core/src/test/scala/org/apache/spark/sql/execution/command/ShowTablesSuiteBase.scala: ## @@ -126,4 +158,258 @@ trait ShowTablesSuiteBase extends QueryTest

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-03 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1381654555 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -4055,19 +4055,28 @@ class AstBuilder extends DataTypeAstBuilder with

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-03 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1381654280 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExtendedExec.scala: ## @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-03 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1381645724 ## sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowTablesSuite.scala: ## @@ -165,4 +154,63 @@ class ShowTablesSuite extends

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-02 Thread via GitHub
panbingkun commented on PR #37588: URL: https://github.com/apache/spark/pull/37588#issuecomment-1791622292 > I think it's pretty close now, thanks for your patience! I will update it again today. Thank you very much for your patience and seriousness, which has been a great help

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-02 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1380287495 ## sql/core/src/test/scala/org/apache/spark/sql/execution/command/ShowTablesSuiteBase.scala: ## @@ -126,4 +158,258 @@ trait ShowTablesSuiteBase extends QueryTest

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-02 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1380274949 ## sql/core/src/test/scala/org/apache/spark/sql/execution/command/ShowTablesSuiteBase.scala: ## @@ -40,6 +40,38 @@ trait ShowTablesSuiteBase extends QueryTest with

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-02 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1380290514 ## sql/core/src/test/scala/org/apache/spark/sql/execution/command/ShowTablesSuiteBase.scala: ## @@ -126,4 +158,258 @@ trait ShowTablesSuiteBase extends QueryTest

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-02 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1380291630 ## sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowTablesSuite.scala: ## @@ -165,4 +154,63 @@ class ShowTablesSuite extends ShowTablesSuiteBase

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-02 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1380268144 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExtendedExec.scala: ## @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-02 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1380283326 ## sql/core/src/test/scala/org/apache/spark/sql/execution/command/ShowTablesSuiteBase.scala: ## @@ -126,4 +158,258 @@ trait ShowTablesSuiteBase extends QueryTest

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-02 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1380247392 ## sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala: ## @@ -2483,7 +2477,7 @@ private[sql] object QueryCompilationErrors extends

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-02 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1380278877 ## sql/core/src/test/scala/org/apache/spark/sql/execution/command/ShowTablesSuiteBase.scala: ## @@ -126,4 +158,258 @@ trait ShowTablesSuiteBase extends QueryTest

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-02 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1380278496 ## sql/core/src/test/scala/org/apache/spark/sql/execution/command/ShowTablesSuiteBase.scala: ## @@ -126,4 +158,258 @@ trait ShowTablesSuiteBase extends QueryTest

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-02 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1380276558 ## sql/core/src/test/scala/org/apache/spark/sql/execution/command/ShowTablesSuiteBase.scala: ## @@ -40,6 +40,38 @@ trait ShowTablesSuiteBase extends QueryTest with

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-02 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1380266348 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExtendedExec.scala: ## @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-02 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1380265564 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExtendedExec.scala: ## @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-02 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1380269913 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala: ## @@ -1090,6 +1090,22 @@ class SessionCatalog( dbViews ++

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-02 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1380268928 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExtendedExec.scala: ## @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-02 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1380263403 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExtendedExec.scala: ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-02 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1380261145 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExtendedExec.scala: ## @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-02 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1380256729 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExtendedExec.scala: ## @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-02 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1380255218 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExtendedExec.scala: ## @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-02 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1380241060 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -4055,19 +4055,28 @@ class AstBuilder extends DataTypeAstBuilder with

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-02 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1380240485 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -4055,19 +4055,28 @@ class AstBuilder extends DataTypeAstBuilder with

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-02 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1380241677 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -4055,19 +4055,28 @@ class AstBuilder extends DataTypeAstBuilder with

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-02 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1380218989 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala: ## @@ -1090,6 +1090,22 @@ class SessionCatalog( dbViews ++

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-01 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1379487429 ## dev/appveyor-install-dependencies.ps1: ## @@ -27,11 +27,13 @@ Function InstallR { $urlPath = "" $latestVer = $(ConvertFrom-JSON $(Invoke-WebRequest

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-01 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1378705860 ## sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala: ## @@ -2483,7 +2477,7 @@ private[sql] object QueryCompilationErrors extends

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-01 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1378701726 ## sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowTablesSuite.scala: ## @@ -165,4 +154,222 @@ class ShowTablesSuite extends

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-11-01 Thread via GitHub
beliefer commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1378438582 ## sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala: ## @@ -2483,7 +2477,7 @@ private[sql] object QueryCompilationErrors extends

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-31 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1378350993 ## sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowTablesSuite.scala: ## @@ -165,4 +154,222 @@ class ShowTablesSuite extends

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-31 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1378345147 ## sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowTablesSuite.scala: ## @@ -165,4 +154,222 @@ class ShowTablesSuite extends

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-31 Thread via GitHub
beliefer commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1377425633 ## sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala: ## @@ -2483,7 +2477,7 @@ private[sql] object QueryCompilationErrors extends

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-31 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1377094224 ## sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala: ## @@ -2483,7 +2477,7 @@ private[sql] object QueryCompilationErrors extends

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-30 Thread via GitHub
beliefer commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1377086123 ## sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala: ## @@ -2483,7 +2477,7 @@ private[sql] object QueryCompilationErrors extends

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-30 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1376969387 ## sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala: ## @@ -2483,7 +2477,7 @@ private[sql] object QueryCompilationErrors extends

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-30 Thread via GitHub
beliefer commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1376219791 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExtendedExec.scala: ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-30 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1376105978 ## sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowTablesSuite.scala: ## @@ -165,4 +154,222 @@ class ShowTablesSuite extends

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-30 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1376099810 ## sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowTablesSuite.scala: ## @@ -165,4 +154,222 @@ class ShowTablesSuite extends

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-30 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1376094564 ## sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowTablesSuite.scala: ## @@ -165,4 +154,222 @@ class ShowTablesSuite extends

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-30 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1376087096 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -4055,19 +4055,28 @@ class AstBuilder extends DataTypeAstBuilder with

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-30 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1376075950 ## sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestUtils.scala: ## @@ -320,6 +320,17 @@ private[sql] trait SQLTestUtilsBase ) } + /** + *

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-30 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1376068633 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExtendedExec.scala: ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-30 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1376065102 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExtendedExec.scala: ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-30 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1376060396 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExtendedExec.scala: ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-30 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1376060024 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExtendedExec.scala: ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-30 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1375785577 ## sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestUtils.scala: ## @@ -320,6 +320,17 @@ private[sql] trait SQLTestUtilsBase ) } + /** + * Drops

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-30 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1375784614 ## sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowTablesSuite.scala: ## @@ -165,4 +154,222 @@ class ShowTablesSuite extends

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-30 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1375784149 ## sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowTablesSuite.scala: ## @@ -165,4 +154,222 @@ class ShowTablesSuite extends

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-30 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1375783886 ## sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowTablesSuite.scala: ## @@ -165,4 +154,222 @@ class ShowTablesSuite extends

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-30 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1375783237 ## sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowTablesSuite.scala: ## @@ -165,4 +154,222 @@ class ShowTablesSuite extends

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-30 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1375781992 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExtendedExec.scala: ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-30 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1375761643 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExtendedExec.scala: ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-30 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1375760595 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExtendedExec.scala: ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-30 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1375756682 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExtendedExec.scala: ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-30 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1375752983 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExtendedExec.scala: ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-30 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1375746540 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -4055,19 +4055,28 @@ class AstBuilder extends DataTypeAstBuilder with

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-29 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1375431259 ## sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala: ## @@ -2133,12 +2133,6 @@ private[sql] object QueryCompilationErrors

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-28 Thread via GitHub
beliefer commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1375347289 ## sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala: ## @@ -2133,12 +2133,6 @@ private[sql] object QueryCompilationErrors extends

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-28 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1375244098 ## sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala: ## @@ -2785,4 +2785,11 @@ private[sql] object QueryExecutionErrors extends

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-28 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1375244071 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala: ## @@ -404,6 +404,17 @@ class DataSourceV2Strategy(session:

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-28 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1375243205 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExec.scala: ## @@ -53,4 +80,103 @@ case class ShowTablesExec( case _ =>

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-28 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1375242759 ## sql/catalyst/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Implicits.scala: ## @@ -30,6 +30,7 @@ import

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-28 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1375242555 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -4055,19 +4055,28 @@ class AstBuilder extends DataTypeAstBuilder with

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-28 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1375241783 ## sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala: ## @@ -2133,12 +2133,6 @@ private[sql] object QueryCompilationErrors

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-28 Thread via GitHub
beliefer commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1375220594 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala: ## @@ -884,19 +884,39 @@ object ShowTables { } /** - * The logical

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-27 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1374601778 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExec.scala: ## @@ -53,4 +80,103 @@ case class ShowTablesExec( case _ =>

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-27 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r137450 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExec.scala: ## @@ -33,17 +41,36 @@ case class ShowTablesExec( output:

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-27 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1374596994 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExec.scala: ## @@ -33,17 +41,36 @@ case class ShowTablesExec( output:

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-27 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1374595749 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala: ## @@ -404,6 +404,17 @@ class DataSourceV2Strategy(session:

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-27 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1374587818 ## sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala: ## @@ -2785,4 +2785,11 @@ private[sql] object QueryExecutionErrors extends

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-27 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1374586437 ## sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala: ## @@ -2785,4 +2785,11 @@ private[sql] object QueryExecutionErrors extends

  1   2   >