Re: [sage-devel] Re: Degree of the zero polynomial ring for `LaurentPolynomialRing`

Mathematically, the degree of a nonzero polynomial is the negative of its valuation at infinity, i.e. the valuation for which 1/x is a uniformiser. On Fri, 1 Mar 2024, 19:29 Travis Scrimshaw, wrote: > Some quick data points: > > - The general graded modules (and hence algebras) code raises an

Re: [sage-devel] Re: Degree of the zero polynomial ring for `LaurentPolynomialRing`

Some quick data points: - The general graded modules (and hence algebras) code raises an error for `0` since it is defined there by the direct summand the element belongs to (and `0` belongs to all of them. - For polynomials, it is very useful to have a single check `f.degree() > k` for some

Re: [sage-devel] Re: Degree of the zero polynomial ring for `LaurentPolynomialRing`

I don't get it - are my previous messages invisible? 1st Message: I don't understand - `degree` doesn't make much sense for Laurent series - there is no way to determine the degree of a LaurentSeries and no way to determine the degree of a LazyLaurentSeries with one minor exception - which is

Re: [sage-devel] Re: Degree of the zero polynomial ring for `LaurentPolynomialRing`

As an aside, the univariate LaurentPolynomialRing had a notion of `valuation` but the multivariate one didn't... In the PR: https://github.com/sagemath/sage/pull/37490 I added random elements but also a notion of valuation() for the multivariate case and just made it act similarly to the

Re: [sage-devel] Re: Degree of the zero polynomial ring for `LaurentPolynomialRing`

On Friday 1 March 2024 at 09:49:15 UTC-8 Giacomo Pope wrote: Following this discussion, I have made a draft PR to change the degree for *only* the LaurentPolynomialRing and I will see if the CI detects anything. https://github.com/sagemath/sage/pull/37513 I agree that if we change the

Re: [sage-devel] Re: Sage's Code of Conduct: proposed changes

There are suggestions along maybe similar lines at https://github.com/sagemath/sage/pull/36844, and I am trying to think of how we might incorporate your suggestions and the other ones. I've had the thought before about other documents (like our department's by-laws) that there should be two

Re: [sage-devel] Re: Degree of the zero polynomial ring for `LaurentPolynomialRing`

On Friday 1 March 2024 at 19:03:35 UTC+1 Dima Pasechnik wrote: On Fri, Mar 1, 2024 at 5:58 PM 'Martin R' via sage-devel < sage-...@googlegroups.com> wrote: I don't understand - `degree` doesn't make much sense for Laurent series - there is no way to determine the degree of a LaurentSeries and

Re: [sage-devel] Permissions on github

On Friday, March 1, 2024 at 9:27:30 AM UTC-8 David Roe wrote: you need some kind of admin privileges in order to add people to Triage More specifically, it is the Maintainer role that is needed for this. I have started to enumerate a number of duties that require the Maintainer role in

Re: [sage-devel] Re: Degree of the zero polynomial ring for `LaurentPolynomialRing`

On Fri, Mar 1, 2024 at 5:58 PM 'Martin R' via sage-devel < sage-devel@googlegroups.com> wrote: > I don't understand - `degree` doesn't make much sense for Laurent series - > there is no way to determine the degree of a LaurentSeries and no way to > determine the degree of a LazyLaurentSeries with

Re: [sage-devel] Re: Degree of the zero polynomial ring for `LaurentPolynomialRing`

On Fri, Mar 1, 2024 at 5:11 PM Nils Bruin wrote: > On Friday 1 March 2024 at 04:26:43 UTC-8 Dima Pasechnik wrote: > > > It seems that exactly the same algorithm will work (I didn't check this!) > for Laurent polynomials (they still form a Euclidean domain), and there you > better set

Re: [sage-devel] Re: Degree of the zero polynomial ring for `LaurentPolynomialRing`

I don't understand - `degree` doesn't make much sense for Laurent series - there is no way to determine the degree of a LaurentSeries and no way to determine the degree of a LazyLaurentSeries with one minor exception - which is when it is known that the series terminates, but that's rare. On

Re: [sage-devel] Re: Degree of the zero polynomial ring for `LaurentPolynomialRing`

Following this discussion, I have made a draft PR to change the degree for *only* the LaurentPolynomialRing and I will see if the CI detects anything. https://github.com/sagemath/sage/pull/37513 I agree that if we change the LaurentPolynomialRing we should also change the `LaurentSeriesRing`,

Re: [sage-devel] Re: Sage's Code of Conduct: proposed changes

Thank you for the thoughtful reply! You gave me a lot to think about, and I'll do so over the weekend, rather than rushing. Best, Martin On Friday 1 March 2024 at 18:21:59 UTC+1 David Roe wrote: > Thank you for starting the conversation Martin. I certainly think that > all of these

Re: [sage-devel] Re: Degree of the zero polynomial ring for `LaurentPolynomialRing`

Could you expand on 'the whole valuation interpretation of "degree" goes out of the window'? What do you mean with "valuation interpretation"? Is raising an exception out of the question? On Friday 1 March 2024 at 18:11:40 UTC+1 Nils Bruin wrote: > On Friday 1 March 2024 at 04:26:43 UTC-8

Re: [sage-devel] Permissions on github

As far as I can tell, you need some kind of admin privileges in order to add people to Triage (which is unfortunate, since membership in this team is critical for our reviewing process). The method that I use is to go here and click on the big green

Re: [sage-devel] Re: Sage's Code of Conduct: proposed changes

Thank you for starting the conversation Martin. I certainly think that all of these suggestions are appropriate to discuss, and that sage-devel is probably a better venue for discussion like this than the PR. On Fri, Mar 1, 2024 at 5:49 AM 'Martin R' via sage-devel < sage-devel@googlegroups.com>

Re: [sage-devel] Re: Degree of the zero polynomial ring for `LaurentPolynomialRing`

On Friday 1 March 2024 at 04:26:43 UTC-8 Dima Pasechnik wrote: It seems that exactly the same algorithm will work (I didn't check this!) for Laurent polynomials (they still form a Euclidean domain), and there you better set degree(0)=-oo, otherwise it's going to be a problem. I think it's

[sage-devel] Permissions on github

I couldn't find the appropriate place to ask (and I think that this should be fixed): how can I give someone the permission to modify labels, I think that's called triage team now? User name would be nadialafreniere. Thank you, Martin -- You received this message because you are subscribed

Re: [sage-devel] Re: Degree of the zero polynomial ring for `LaurentPolynomialRing`

On Fri, Mar 1, 2024 at 11:41 AM Oscar Benjamin wrote: > On Fri, 1 Mar 2024 at 11:15, John Cremona wrote: > > > > On Fri, 1 Mar 2024 at 11:03, Dima Pasechnik wrote: > >> > >> On Fri, Mar 1, 2024 at 10:24 AM John Cremona > wrote: > >>> > >>> On Fri, 1 Mar 2024 at 10:04, Dima Pasechnik wrote: >

Re: [sage-devel] Re: Degree of the zero polynomial ring for `LaurentPolynomialRing`

On Fri, 1 Mar 2024 at 11:51, 'Martin R' via sage-devel wrote: > On Friday 1 March 2024 at 12:15:36 UTC+1 John Cremona wrote: > On Fri, 1 Mar 2024 at 11:03, Dima Pasechnik wrote: > > OTOH, setting the degree of 0 to be -oo has an obvious advantage: it > automaticlly gives mathematically correct

Re: [sage-devel] Re: Degree of the zero polynomial ring for `LaurentPolynomialRing`

On Friday 1 March 2024 at 12:15:36 UTC+1 John Cremona wrote: On Fri, 1 Mar 2024 at 11:03, Dima Pasechnik wrote: On Fri, Mar 1, 2024 at 10:24 AM John Cremona wrote: On Fri, 1 Mar 2024 at 10:04, Dima Pasechnik wrote: On 1 March 2024 09:07:26 GMT, 'Martin R' via sage-devel <

Re: [sage-devel] Re: Degree of the zero polynomial ring for `LaurentPolynomialRing`

On Fri, 1 Mar 2024 at 11:15, John Cremona wrote: > > On Fri, 1 Mar 2024 at 11:03, Dima Pasechnik wrote: >> >> On Fri, Mar 1, 2024 at 10:24 AM John Cremona wrote: >>> >>> On Fri, 1 Mar 2024 at 10:04, Dima Pasechnik wrote: On 1 March 2024 09:07:26 GMT, 'Martin R' via

Re: [sage-devel] Re: Degree of the zero polynomial ring for `LaurentPolynomialRing`

On Fri, 1 Mar 2024 at 11:03, Dima Pasechnik wrote: > > > On Fri, Mar 1, 2024 at 10:24 AM John Cremona > wrote: > >> >> >> On Fri, 1 Mar 2024 at 10:04, Dima Pasechnik wrote: >> >>> >>> >>> On 1 March 2024 09:07:26 GMT, 'Martin R' via sage-devel < >>> sage-devel@googlegroups.com> wrote: >>> >I'd

Re: [sage-devel] Re: Degree of the zero polynomial ring for `LaurentPolynomialRing`

On Fri, Mar 1, 2024 at 10:24 AM John Cremona wrote: > > > On Fri, 1 Mar 2024 at 10:04, Dima Pasechnik wrote: > >> >> >> On 1 March 2024 09:07:26 GMT, 'Martin R' via sage-devel < >> sage-devel@googlegroups.com> wrote: >> >I'd be OK with raising an exception or with -oo, but it should be >>

[sage-devel] Re: Sage's Code of Conduct: proposed changes

I would like to ask whether we might want to add some of the following to the code of conduct, I could not find it covered there. I admit that it is unclear to me whether the discussion should be on pull requests only. I don't want to add the following to John's pull request, because it

Re: [sage-devel] Re: Degree of the zero polynomial ring for `LaurentPolynomialRing`

On Fri, 1 Mar 2024 at 10:04, Dima Pasechnik wrote: > > > On 1 March 2024 09:07:26 GMT, 'Martin R' via sage-devel < > sage-devel@googlegroups.com> wrote: > >I'd be OK with raising an exception or with -oo, but it should be > uniform, > >and I think it should be the same for polynomials, Laurent

Re: [sage-devel] Re: Degree of the zero polynomial ring for `LaurentPolynomialRing`

On 1 March 2024 09:07:26 GMT, 'Martin R' via sage-devel wrote: >I'd be OK with raising an exception or with -oo, but it should be uniform, >and I think it should be the same for polynomials, Laurent polynomials and >in the same spirit for degree and valuation. > >It might be best to raise

Re: [sage-devel] Re: Degree of the zero polynomial ring for `LaurentPolynomialRing`

And that will be a problem when `R` is a laurent polynomial ring. On 01/03/2024 09:12, Gareth Ma wrote: I lean towards setting it to -∞. While we are at this, how should `R.random_element` be called? The method currently takes a `degree` argument, which is a tuple of lower and upper bound,

Re: [sage-devel] Re: Degree of the zero polynomial ring for `LaurentPolynomialRing`

I lean towards setting it to -∞. While we are at this, how should `R.random_element` be called? The method currently takes a `degree` argument, which is a tuple of lower and upper bound, and if the user sets the lower bound to -1, then `0` is a possible outcome. Would the user call it with

Re: [sage-devel] Re: Degree of the zero polynomial ring for `LaurentPolynomialRing`

I'd be OK with raising an exception or with -oo, but it should be uniform, and I think it should be the same for polynomials, Laurent polynomials and in the same spirit for degree and valuation. It might be best to raise an exception, because this ensures that the zero polynomial gets special