Re: [PATCH v6 01/11] linux-headers: Update to kernel headers to add venus capset

2024-01-02 Thread Huang Rui
On Tue, Jan 02, 2024 at 06:42:44PM +0800, Marc-André Lureau wrote: > Hi > > On Thu, Dec 21, 2023 at 10:55 AM Akihiko Odaki > wrote: > > > > On 2023/12/19 23:14, Peter Maydell wrote: > > > On Tue, 19 Dec 2023 at 13:49, Huang Rui wrote: > > >> > > >> On Tue, Dec 19, 2023 at 08:20:22PM +0800,

Re: [PATCH v6 01/11] linux-headers: Update to kernel headers to add venus capset

2024-01-02 Thread Huang Rui
On Tue, Dec 19, 2023 at 10:14:28PM +0800, Peter Maydell wrote: > On Tue, 19 Dec 2023 at 13:49, Huang Rui wrote: > > > > On Tue, Dec 19, 2023 at 08:20:22PM +0800, Akihiko Odaki wrote: > > > On 2023/12/19 16:53, Huang Rui wrote: > > > > Sync up kernel headers to update venus macro till they are

Re: [PATCH v6 01/11] linux-headers: Update to kernel headers to add venus capset

2024-01-02 Thread Huang Rui
On Tue, Dec 19, 2023 at 08:20:22PM +0800, Akihiko Odaki wrote: > On 2023/12/19 16:53, Huang Rui wrote: > > Sync up kernel headers to update venus macro till they are merged into > > mainline. > > Thanks for sorting things out with the kernel and spec. > > > > > Signed-off-by: Huang Rui > > ---

Re: Xen 4.19 release schedule proposal

2024-01-02 Thread Juergen Gross
On 02.01.24 17:59, Oleksii wrote: Dear community, Wishing you a Happy New Year! I'd like to propose the release schedule for Xen 4.19. Based on the previous release schedules [1] and [2], it seems the next release date should be on Wednesday, July 10, 2024: ** Proposed option: Wed Jul 10,

Xen and Qemu virtio question

2024-01-02 Thread Peng Fan
Hi Vikram, Oleksii I follow the slide virtio for Xen on ARM[1], but I met some issues, and stuck for about two days. I use upstream lastest qemu repo master branch, not qemu-xen.git repo. My start command as below[2], but seems I need first `xl create domu.cfg`, otherwise it will fail, because

Re: Clang-format configuration discussion - pt 2

2024-01-02 Thread Stefano Stabellini
On Thu, 7 Dec 2023, Julien Grall wrote: > > > > Most modern languages, including golang (and I think rust) have > > > > built-in style correctors (`go fmt` is go's official one). If you > > > > haven't worked with an automatic style checker / fixer, you don't know > > > > how much time, hassle,

RE: [PATCH v13 01/35] x86/cpufeatures,opcode,msr: Add the WRMSRNS instruction support

2024-01-02 Thread Li, Xin3
> > Subject: Re: [PATCH v13 01/35] x86/cpufeatures,opcode,msr: Add the > WRMSRNS instruction support > > Or simply "x86/fred: Add ... " Do I need to send an updated patch? Or just leave it to the maintainer who is going to take care of it? > > Other than that, > > Acked-by: Borislav Petkov

Re: [PATCH v2 1/5] system/cpus: rename qemu_mutex_lock_iothread() to bql_lock()

2024-01-02 Thread Bernhard Beschow
Am 12. Dezember 2023 15:39:00 UTC schrieb Stefan Hajnoczi : >The Big QEMU Lock (BQL) has many names and they are confusing. The >actual QemuMutex variable is called qemu_global_mutex but it's commonly >referred to as the BQL in discussions and some code comments. The >locking APIs, however, are

Re: [PATCH v11 10/17] vpci/header: handle p2m range sets per BAR

2024-01-02 Thread Stewart Hildebrand
On 12/1/23 20:27, Volodymyr Babchuk wrote: > diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c > index 43216429d9..7c84cee5d1 100644 > --- a/xen/drivers/vpci/header.c > +++ b/xen/drivers/vpci/header.c > @@ -598,6 +675,18 @@ static void cf_check rom_write( > rom->addr =

Re: [PATCH v11 07/17] vpci/header: implement guest BAR register handlers

2024-01-02 Thread Stewart Hildebrand
On 12/21/23 10:43, Roger Pau Monné wrote: > On Sat, Dec 02, 2023 at 01:27:04AM +, Volodymyr Babchuk wrote: >> From: Oleksandr Andrushchenko >> >> Add relevant vpci register handlers when assigning PCI device to a domain >> and remove those when de-assigning. This allows having different >>

Re: XEN virtio question

2024-01-02 Thread Stefano Stabellini
Hi Peng, Let me CC Vikram who might have seen this. On Tue, 2 Jan 2024, Peng Fan wrote: > All, > > I am trying to setup xen virtio on NXP i.MX9, but when build xen tools, > I always met qemu build error, such as: > > In file included from ../qemu-xen-dir-remote/hw/xen/xen-operations.c:16: >

Re: [BUG]i2c_hid_acpi broken with 4.17.2 on Framework Laptop 13 AMD

2024-01-02 Thread Sébastien Chaumat
> output of gpioinfo > > kernel alone : > > line 5: unnamed input active-low consumer=interrupt > line 84: unnamed input active-low consumer=interrupt > > xen: > > line 5: unnamed input active-low > line 84: unnamed input

Re: [PATCH v2 15/29] tools/libs/light: add backend type for 9pfs PV devices

2024-01-02 Thread Nick Rosbrook
On Wed, Dec 6, 2023 at 1:53 PM Jason Andryuk wrote: > > On Wed, Dec 6, 2023 at 12:44 PM Nick Rosbrook wrote: > > > > On Wed, Dec 6, 2023 at 9:36 AM Jason Andryuk wrote: > > > FYI, these IDL changes will require golang binding regeneration. > > > (Maybe we shouldn't have generated code checked

Re: [PATCH v2 1/2] xen/x86: io_apic: Introduce a command line option to skip timer check

2024-01-02 Thread Julien Grall
Hi Jan, On 14/12/2023 10:35, Jan Beulich wrote: On 14.12.2023 11:14, Julien Grall wrote: On 14/12/2023 10:10, Jan Beulich wrote: On 11.12.2023 13:23, Julien Grall wrote: --- a/xen/arch/x86/io_apic.c +++ b/xen/arch/x86/io_apic.c @@ -57,6 +57,14 @@ bool __initdata ioapic_ack_forced; int

Re: [PATCH v11 05/17] vpci: add hooks for PCI device assign/de-assign

2024-01-02 Thread Stewart Hildebrand
On 12/21/23 10:21, Roger Pau Monné wrote: > On Sat, Dec 02, 2023 at 01:27:03AM +, Volodymyr Babchuk wrote: >> From: Oleksandr Andrushchenko >> >> When a PCI device gets assigned/de-assigned we need to >> initialize/de-initialize vPCI state for the device. >> >> Also, rename

Re: [PATCH v11 05/17] vpci: add hooks for PCI device assign/de-assign

2024-01-02 Thread Stewart Hildebrand
On 12/22/23 03:52, Jan Beulich wrote: > On 02.12.2023 02:27, Volodymyr Babchuk wrote: >> @@ -886,6 +890,10 @@ static int deassign_device(struct domain *d, uint16_t >> seg, uint8_t bus, >> >> pdev->fault.count = 0; >> >> +write_lock(>pci_lock); >> +ret = vpci_assign_device(pdev);

Re: [PATCH v11 03/17] vpci: use per-domain PCI lock to protect vpci structure

2024-01-02 Thread Stewart Hildebrand
On 12/21/23 09:05, Roger Pau Monné wrote: > On Sat, Dec 02, 2023 at 01:27:03AM +, Volodymyr Babchuk wrote: >> From: Oleksandr Andrushchenko >> >> Use a previously introduced per-domain read/write lock to check >> whether vpci is present, so we are sure there are no accesses to the >> contents

Re: Xen 4.19 release schedule proposal

2024-01-02 Thread Oleksii
Something went wrong, and this email wasn't sent as a separate topic, so I re-sent it. Sorry for any inconvenience. ~ Oleksii On Tue, 2024-01-02 at 18:59 +0200, Oleksii wrote: > Dear community, > > Wishing you a Happy New Year! > > I'd like to propose the release schedule for Xen 4.19. > >

Xen 4.19 release schedule proposal

2024-01-02 Thread Oleksii
Dear community, Wishing you a Happy New Year! I'd like to propose the release schedule for Xen 4.19. Based on the previous release schedules [1] and [2], it seems the next release date should be on Wednesday, July 10, 2024: ** Proposed option: Wed Jul 10, 2024 ** (+9 months from Xen 4.18

Xen 4.19 release schedule proposal

2024-01-02 Thread Oleksii
Dear community, Wishing you a Happy New Year! I'd like to propose the release schedule for Xen 4.19. Based on the previous release schedules [1] and [2], it seems the next release date should be on Wednesday, July 10, 2024: ** Proposed option: Wed Jul 10, 2024 ** (+9 months from Xen 4.18

Re: [PATCH v3 5/5] Rename "QEMU global mutex" to "BQL" in comments and docs

2024-01-02 Thread Cédric Le Goater
On 1/2/24 16:35, Stefan Hajnoczi wrote: The term "QEMU global mutex" is identical to the more widely used Big QEMU Lock ("BQL"). Update the code comments and documentation to use "BQL" instead of "QEMU global mutex". Signed-off-by: Stefan Hajnoczi Acked-by: Markus Armbruster Reviewed-by:

Re: [PATCH v3 4/5] Replace "iothread lock" with "BQL" in comments

2024-01-02 Thread Cédric Le Goater
On 1/2/24 16:35, Stefan Hajnoczi wrote: The term "iothread lock" is obsolete. The APIs use Big QEMU Lock (BQL) in their names. Update the code comments to use "BQL" instead of "iothread lock". Signed-off-by: Stefan Hajnoczi Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater

[PATCH v3 1/5] system/cpus: rename qemu_mutex_lock_iothread() to bql_lock()

2024-01-02 Thread Stefan Hajnoczi
The Big QEMU Lock (BQL) has many names and they are confusing. The actual QemuMutex variable is called qemu_global_mutex but it's commonly referred to as the BQL in discussions and some code comments. The locking APIs, however, are called qemu_mutex_lock_iothread() and

[PATCH v3 5/5] Rename "QEMU global mutex" to "BQL" in comments and docs

2024-01-02 Thread Stefan Hajnoczi
The term "QEMU global mutex" is identical to the more widely used Big QEMU Lock ("BQL"). Update the code comments and documentation to use "BQL" instead of "QEMU global mutex". Signed-off-by: Stefan Hajnoczi Acked-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé ---

[PATCH v3 2/5] qemu/main-loop: rename QEMU_IOTHREAD_LOCK_GUARD to BQL_LOCK_GUARD

2024-01-02 Thread Stefan Hajnoczi
The name "iothread" is overloaded. Use the term Big QEMU Lock (BQL) instead, it is already widely used and unambiguous. Signed-off-by: Stefan Hajnoczi Reviewed-by: Paul Durrant Acked-by: David Woodhouse Reviewed-by: Cédric Le Goater Acked-by: Ilya Leoshkevich --- include/qemu/main-loop.h |

[PATCH v3 4/5] Replace "iothread lock" with "BQL" in comments

2024-01-02 Thread Stefan Hajnoczi
The term "iothread lock" is obsolete. The APIs use Big QEMU Lock (BQL) in their names. Update the code comments to use "BQL" instead of "iothread lock". Signed-off-by: Stefan Hajnoczi Reviewed-by: Philippe Mathieu-Daudé --- docs/devel/reset.rst | 2 +- hw/display/qxl.h

[PATCH v3 3/5] qemu/main-loop: rename qemu_cond_wait_iothread() to qemu_cond_wait_bql()

2024-01-02 Thread Stefan Hajnoczi
The name "iothread" is overloaded. Use the term Big QEMU Lock (BQL) instead, it is already widely used and unambiguous. Signed-off-by: Stefan Hajnoczi Reviewed-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé --- include/qemu/main-loop.h | 10 +-

[PATCH v3 0/5] Make Big QEMU Lock naming consistent

2024-01-02 Thread Stefan Hajnoczi
v3: - Rebase - Define bql_lock() macro on a single line [Akihiko Odaki] v2: - Rename APIs bql_*() [PeterX] - Spell out "Big QEMU Lock (BQL)" in doc comments [PeterX] - Rename "iolock" variables in hw/remote/mpqemu-link.c [Harsh] - Fix bql_auto_lock() indentation in Patch 2 [Ilya] - "with BQL

Re: [PATCH v13 01/35] x86/cpufeatures,opcode,msr: Add the WRMSRNS instruction support

2024-01-02 Thread Borislav Petkov
On Tue, Dec 05, 2023 at 02:49:50AM -0800, Xin Li wrote: > Subject: Re: [PATCH v13 01/35] x86/cpufeatures,opcode,msr: Add the WRMSRNS > instruction support Or simply "x86/fred: Add ... " Other than that, Acked-by: Borislav Petkov (AMD) -- Regards/Gruss, Boris.

Re: [PATCH v2 1/5] system/cpus: rename qemu_mutex_lock_iothread() to bql_lock()

2024-01-02 Thread Stefan Hajnoczi
On Wed, Dec 13, 2023 at 03:37:00PM +0900, Akihiko Odaki wrote: > On 2023/12/13 0:39, Stefan Hajnoczi wrote: > > @@ -312,58 +312,58 @@ bool qemu_in_main_thread(void); > > } while (0) > > /** > > - * qemu_mutex_lock_iothread: Lock the main loop mutex. > > + * bql_lock: Lock the Big QEMU Lock

Re: Possible bug in Xen

2024-01-02 Thread Joe Tretter
Happy New Year! I think it's time I send you an update: I have spent a considerable amount of time trying to get the latest firmware working, but I find a way that does the job. When I replaced the file with yours, the machine directly restarts on application of the firmware. All ways I have

Re: [PATCH v2 1/1] virgl: Implement resource_query_layout

2024-01-02 Thread Marc-André Lureau
Hi On Thu, Dec 21, 2023 at 3:36 PM Julia Zhang wrote: > > From: Daniel Stone > > A new ioctl to shuttle information between host and guest about the > actual buffer allocation, which can be used for interop between GL and > Vulkan when supporting standard window systems. > The command hasn't

Re: [PATCH v6 10/11] virtio-gpu: Initialize Venus

2024-01-02 Thread Marc-André Lureau
Hi On Tue, Dec 19, 2023 at 11:55 AM Huang Rui wrote: > > From: Antonio Caggiano > > Request Venus when initializing VirGL. > > Signed-off-by: Antonio Caggiano > Signed-off-by: Huang Rui > --- > > Changes in v6: > - Remove the unstable API flags check because virglrenderer is already 1.0. > -

Re: [PATCH v6 08/11] virtio-gpu: Resource UUID

2024-01-02 Thread Marc-André Lureau
Hi On Tue, Dec 19, 2023 at 11:55 AM Huang Rui wrote: > > From: Antonio Caggiano > > Enable resource UUID feature and implement command resource assign UUID. > This is done by introducing a hash table to map resource IDs to their > UUIDs. I agree with Akihiko, what about putting QemuUUID in

Re: [PATCH v6 07/11] virtio-gpu: Handle resource blob commands

2024-01-02 Thread Marc-André Lureau
Hi On Tue, Dec 19, 2023 at 11:55 AM Huang Rui wrote: > > From: Antonio Caggiano > > Support BLOB resources creation, mapping and unmapping by calling the > new stable virglrenderer 0.10 interface. Only enabled when available and > via the blob config. E.g. -device virtio-vga-gl,blob=true > >

[xen-unstable test] 184243: tolerable FAIL

2024-01-02 Thread osstest service owner
flight 184243 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/184243/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-libvirt-raw 13 guest-startfail pass in 184241 Tests which did not succeed,

Re: [PATCH v6 05/11] virtio-gpu: Introduce virgl_gpu_resource structure

2024-01-02 Thread Marc-André Lureau
Hi On Tue, Dec 19, 2023 at 11:55 AM Huang Rui wrote: > > Introduce a new virgl_gpu_resource data structure and helper functions > for virgl. It's used to add new member which is specific for virgl in > following patches of blob memory support. > > Signed-off-by: Huang Rui > --- > > New patch: >

Re: [PATCH v6 04/11] virtio-gpu: Don't require udmabuf when blobs and virgl are enabled

2024-01-02 Thread Marc-André Lureau
On Tue, Dec 19, 2023 at 11:54 AM Huang Rui wrote: > > From: Dmitry Osipenko > > The udmabuf usage is mandatory when virgl is disabled and blobs feature > enabled in the Qemu machine configuration. If virgl and blobs are enabled, > then udmabuf requirement is optional. Since udmabuf isn't widely

Re: [PATCH v6 03/11] virtio-gpu: Support context init feature with virglrenderer

2024-01-02 Thread Marc-André Lureau
Hi On Tue, Dec 19, 2023 at 11:54 AM Huang Rui wrote: > > Patch "virtio-gpu: CONTEXT_INIT feature" has added the context_init > feature flags. > We would like to enable the feature with virglrenderer, so add to create > virgl renderer context with flags using context_id when valid. > >

Re: [PATCH v6 01/11] linux-headers: Update to kernel headers to add venus capset

2024-01-02 Thread Marc-André Lureau
Hi On Thu, Dec 21, 2023 at 10:55 AM Akihiko Odaki wrote: > > On 2023/12/19 23:14, Peter Maydell wrote: > > On Tue, 19 Dec 2023 at 13:49, Huang Rui wrote: > >> > >> On Tue, Dec 19, 2023 at 08:20:22PM +0800, Akihiko Odaki wrote: > >>> On 2023/12/19 16:53, Huang Rui wrote: > Sync up kernel

[PATCH v5 13/13] xen/arm: add cache coloring support for Xen

2024-01-02 Thread Carlo Nonato
This commit adds the cache coloring support for Xen own physical space. It extends the implementation of setup_pagetables() to make use of Xen cache coloring configuration. Page tables construction is essentially the same except for the fact that PTEs point to a new temporary mapped, physically

[PATCH v5 12/13] xen/arm: add Xen cache colors command line parameter

2024-01-02 Thread Carlo Nonato
From: Luca Miccio This commit adds a new command line parameter to configure Xen cache colors. These colors can be dumped with the cache coloring info debug-key. By default, Xen uses the first color. Benchmarking the VM interrupt response time provides an estimation of LLC usage by Xen's most

[PATCH v5 01/13] xen/common: add cache coloring common code

2024-01-02 Thread Carlo Nonato
This commit adds the Last Level Cache (LLC) coloring common header, Kconfig options and functions. Since this is an arch specific feature, actual implementation is postponed to later patches and Kconfig options are placed under xen/arch. LLC colors are a property of the domain, so the domain

[PATCH v5 10/13] xen/arm: use domain memory to allocate p2m page tables

2024-01-02 Thread Carlo Nonato
Cache colored domains can benefit from having p2m page tables allocated with the same coloring schema so that isolation can be achieved also for those kind of memory accesses. In order to do that, the domain struct is passed to the allocator and the MEMF_no_owner flag is used. This will be useful

[PATCH v5 07/13] xen/page_alloc: introduce init_free_page_fields() helper

2024-01-02 Thread Carlo Nonato
Introduce a new helper to initialize fields that have different uses for free pages. Signed-off-by: Carlo Nonato Signed-off-by: Marco Solieri --- v5: - new patch --- xen/common/page_alloc.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git

[PATCH v5 03/13] xen/arm: add Dom0 cache coloring support

2024-01-02 Thread Carlo Nonato
This commit allows the user to set the cache coloring configuration for Dom0 via a command line parameter. Since cache coloring and static memory are incompatible, direct mapping Dom0 isn't possible when coloring is enabled. A common configuration syntax for cache colors is also introduced.

[PATCH v5 04/13] xen: extend domctl interface for cache coloring

2024-01-02 Thread Carlo Nonato
This commit updates the domctl interface to allow the user to set cache coloring configurations from the toolstack. It also implements the functionality for arm64. Based on original work from: Luca Miccio Signed-off-by: Carlo Nonato Signed-off-by: Marco Solieri --- v5: - added a new hypercall

[PATCH v5 09/13] xen: add cache coloring allocator for domains

2024-01-02 Thread Carlo Nonato
This commit adds a new memory page allocator that implements the cache coloring mechanism. The allocation algorithm enforces equal frequency distribution of cache partitions, following the coloring configuration of a domain. This allows an even utilization of cache sets for every domain. Pages

[PATCH v5 08/13] xen/page_alloc: introduce preserved page flags macro

2024-01-02 Thread Carlo Nonato
PGC_static and PGC_extra are flags that needs to be preserved when assigning a page. Define a new macro that groups those flags and use it instead of or'ing every time. The new macro is used also in free_heap_pages() allowing future commits to extended it with other flags that must stop merging,

[PATCH v5 11/13] Revert "xen/arm: Remove unused BOOT_RELOC_VIRT_START"

2024-01-02 Thread Carlo Nonato
This reverts commit 0c18fb76323bfb13615b6f13c98767face2d8097 (not clean). This is not a clean revert since the rework of the memory layout, but it is sufficiently similar to a clean one. The only difference is that the BOOT_RELOC_VIRT_START must match the new layout. Cache coloring support for

[PATCH v5 06/13] xen/arm: add support for cache coloring configuration via device-tree

2024-01-02 Thread Carlo Nonato
This commit adds the "llc-colors" Device Tree attribute that can be used for DomUs and Dom0less color configurations. The syntax is the same used for every color config. Based on original work from: Luca Miccio Signed-off-by: Carlo Nonato Signed-off-by: Marco Solieri --- v5: - static-mem

[PATCH v5 00/13] Arm cache coloring

2024-01-02 Thread Carlo Nonato
Shared caches in multi-core CPU architectures represent a problem for predictability of memory access latency. This jeopardizes applicability of many Arm platform in real-time critical and mixed-criticality scenarios. We introduce support for cache partitioning with page coloring, a transparent

[PATCH v5 02/13] xen/arm: add cache coloring initialization

2024-01-02 Thread Carlo Nonato
This commit implements functions declared in the LLC coloring common header for arm64 and adds documentation. It also adds two command line options: a runtime switch for the cache coloring feature and the LLC way size parameter. The feature init function consists of an auto probing of the cache

[PATCH v5 05/13] tools: add support for cache coloring configuration

2024-01-02 Thread Carlo Nonato
Add a new "llc_colors" parameter that defines the LLC color assignment for a domain. The user can specify one or more color ranges using the same syntax used everywhere else for color config described in the documentation. The parameter is defined as a list of strings that represent the color