Re: [PATCH v5 10/23] xen/riscv: introduces acrquire, release and full barriers

2024-03-04 Thread Jan Beulich
On 26.02.2024 18:38, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich albeit ... > --- /dev/null > +++ b/xen/arch/riscv/include/asm/fence.h > @@ -0,0 +1,9 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later */ > +#ifndef _ASM_RISCV_FENCE_H > +#define

Re: [PATCH 1/2] xen/*/nospec: Provide common versions of evaluate_nospec/block_speculation

2024-03-04 Thread Jan Beulich
On 04.03.2024 17:10, Andrew Cooper wrote: > --- a/xen/include/xen/nospec.h > +++ b/xen/include/xen/nospec.h > @@ -9,6 +9,29 @@ > > #include > > +/* > + * Protect a conditional branch from bad speculation. Architectures *must* > + * provide arch_evaluate_nospec() for this to be effective. >

Re: [PATCH 2/2] xen/nospec: Allow evaluate_nospec() to short circuit constant expressions

2024-03-04 Thread Jan Beulich
On 04.03.2024 17:10, Andrew Cooper wrote: > --- a/xen/include/xen/nospec.h > +++ b/xen/include/xen/nospec.h > @@ -18,6 +18,15 @@ static always_inline bool evaluate_nospec(bool cond) > #ifndef arch_evaluate_nospec > #define arch_evaluate_nospec(cond) cond > #endif > + > +/* > + * If the

Re: [PATCH 1/2] xen/*/nospec: Provide common versions of evaluate_nospec/block_speculation

2024-03-04 Thread Jan Beulich
On 04.03.2024 17:10, Andrew Cooper wrote: > It is daft to require all architectures to provide empty implementations of > this functionality. > > Provide evaluate_nospec() and block_speculation() unconditionally in > xen/nospec.h with architectures able to opt in by providing suitable arch >

Re: [PATCH 1/2] xen/*/nospec: Provide common versions of evaluate_nospec/block_speculation

2024-03-04 Thread Jan Beulich
On 04.03.2024 18:40, Julien Grall wrote: > Hi Andrew, > > On 04/03/2024 17:07, Andrew Cooper wrote: >> On 04/03/2024 4:55 pm, Jan Beulich wrote: >>> On 04.03.2024 17:46, Julien Grall wrote: On 04/03/2024 16:41, Jan Beulich wrote: > On 04.03.2024 17:31, Julien Grall wrote: >> On

Re: [XEN PATCH 10/10] xen/keyhandler: address violations of MISRA C Rule 20.7

2024-03-04 Thread Jan Beulich
On 05.03.2024 03:03, Stefano Stabellini wrote: > On Mon, 4 Mar 2024, Jan Beulich wrote: >> On 02.03.2024 02:37, Stefano Stabellini wrote: >>> On Fri, 1 Mar 2024, Jan Beulich wrote: On 29.02.2024 23:57, Stefano Stabellini wrote: > On Thu, 29 Feb 2024, Nicola Vetrini wrote: >> MISRA C

Re: [PATCH v2 2/3] docs/misra/rules.rst: add rule 5.5

2024-03-04 Thread Jan Beulich
On 05.03.2024 02:49, Stefano Stabellini wrote: > On Mon, 4 Mar 2024, Jan Beulich wrote: >> On 04.03.2024 16:39, Federico Serafini wrote: >>> On 04/03/24 15:17, Jan Beulich wrote: On 04.03.2024 14:31, Federico Serafini wrote: > On 01/03/24 09:06, Jan Beulich wrote: >> On 01.03.2024

[xen-unstable test] 184905: tolerable FAIL - PUSHED

2024-03-04 Thread osstest service owner
flight 184905 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/184905/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail blocked in 184833 test-armhf-armhf-libvirt 16

[PATCH v4 bpf-next 1/2] mm: Enforce VM_IOREMAP flag and range in ioremap_page_range.

2024-03-04 Thread Alexei Starovoitov
From: Alexei Starovoitov There are various users of get_vm_area() + ioremap_page_range() APIs. Enforce that get_vm_area() was requested as VM_IOREMAP type and range passed to ioremap_page_range() matches created vm_area to avoid accidentally ioremap-ing into wrong address range. Reviewed-by:

[PATCH v4 bpf-next 2/2] mm: Introduce VM_SPARSE kind and vm_area_[un]map_pages().

2024-03-04 Thread Alexei Starovoitov
From: Alexei Starovoitov vmap/vmalloc APIs are used to map a set of pages into contiguous kernel virtual space. get_vm_area() with appropriate flag is used to request an area of kernel address range. It's used for vmalloc, vmap, ioremap, xen use cases. - vmalloc use case dominates the usage.

[PATCH v4 bpf-next 0/2] mm: Enforce ioremap address space and introduce sparse vm_area

2024-03-04 Thread Alexei Starovoitov
From: Alexei Starovoitov v3 -> v4 - dropped VM_XEN patch for now. It will be in the follow up. - fixed constant as pointed out by Mike v2 -> v3 - added Christoph's reviewed-by to patch 1 - cap commit log lines to 75 chars - factored out common checks in patch 3 into helper - made

Re: [XEN PATCH 10/10] xen/keyhandler: address violations of MISRA C Rule 20.7

2024-03-04 Thread Stefano Stabellini
On Mon, 4 Mar 2024, Jan Beulich wrote: > On 02.03.2024 02:37, Stefano Stabellini wrote: > > On Fri, 1 Mar 2024, Jan Beulich wrote: > >> On 29.02.2024 23:57, Stefano Stabellini wrote: > >>> On Thu, 29 Feb 2024, Nicola Vetrini wrote: > MISRA C Rule 20.7 states: "Expressions resulting from the

Re: [XEN PATCH] automation/eclair: add deviation for MISRA C:2012 Rule 16.6

2024-03-04 Thread Stefano Stabellini
On Mon, 4 Mar 2024, Federico Serafini wrote: > Update ECLAIR configuration to take into account the deviations > agreed during MISRA meetings. > > Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini

Re: [PATCH v2 2/3] docs/misra/rules.rst: add rule 5.5

2024-03-04 Thread Stefano Stabellini
On Mon, 4 Mar 2024, Jan Beulich wrote: > On 04.03.2024 16:39, Federico Serafini wrote: > > On 04/03/24 15:17, Jan Beulich wrote: > >> On 04.03.2024 14:31, Federico Serafini wrote: > >>> On 01/03/24 09:06, Jan Beulich wrote: > On 01.03.2024 00:28, Stefano Stabellini wrote: > > On Wed, 14

Re: [XEN PATCH 02/10] xen/arm: address some violations of MISRA C Rule 20.7

2024-03-04 Thread Stefano Stabellini
On Mon, 4 Mar 2024, Nicola Vetrini wrote: > Hi, > > as the maintainers of this subsystem, would you prefer Jan's version or the > one in the patch? > Both are fine w.r.t MISRA Rule 20.7 because the macro arguments themselves are > parenthesized. I prefer Jan's version. Thanks for asking Nicola.

RE: [PATCH] MAINTAINERS: drop AMD SVM and Intel VT-x sections

2024-03-04 Thread Tian, Kevin
> From: Jan Beulich > Sent: Monday, March 4, 2024 5:28 PM > > We'd like to thank the VT-x maintainers for their past contributions, > while at the same time we'd like to reflect reality as it has been for > quite some time. Have VT-x maintainership (and for symmetry also AMD > SVM's) fall back

Re: [PATCH v2 bpf-next 2/3] mm, xen: Separate xen use cases from ioremap.

2024-03-04 Thread Alexei Starovoitov
On Sun, Mar 3, 2024 at 11:55 PM Mike Rapoport wrote: > > On Fri, Feb 23, 2024 at 03:57:27PM -0800, Alexei Starovoitov wrote: > > From: Alexei Starovoitov > > > > xen grant table and xenbus ring are not ioremap the way arch specific code > > is using it, > > so let's add VM_XEN flag to separate

Re: AMD-Vi issue

2024-03-04 Thread Elliott Mitchell
On Mon, Mar 04, 2024 at 11:55:07PM +, Andrew Cooper wrote: > On 25/01/2024 8:24 pm, Elliott Mitchell wrote: > > The original observation features MD-RAID1 using a pair of Samsung > > SATA-attached flash devices. The main line shows up in `xl dmesg`: > > > > (XEN) AMD-Vi: IO_PAGE_FAULT:

Re: [PATCH] xen/common: Do not allocate magic pages 1:1 for direct mapped domains

2024-03-04 Thread Henry Wang
Hi Julien, On 3/5/2024 2:38 AM, Julien Grall wrote: On 01/03/2024 03:03, Henry Wang wrote: Hi Julien, Hi Henry, On 2/28/2024 8:27 PM, Julien Grall wrote: Hi Henry, ...here basically means we want to do the finding of the unused region in toolstack. Since currently what we care about is

Re: AMD-Vi issue

2024-03-04 Thread Andrew Cooper
On 25/01/2024 8:24 pm, Elliott Mitchell wrote: > The original observation features MD-RAID1 using a pair of Samsung > SATA-attached flash devices. The main line shows up in `xl dmesg`: > > (XEN) AMD-Vi: IO_PAGE_FAULT: :bb:dd.f d0 addr ff???000 flags 0x8 I You have a device which is

Re: Xen 4.18rc/ARM64 on Raspberry Pi 4B: Traffic in DomU crashing Dom0 when using VLANs

2024-03-04 Thread Julien Grall
Hi Paul, On 01/03/2024 19:37, Paul Leiber wrote: Stopping xen-watchdog prevents the reboot. However, when triggering traffic on the VLAN, Dom0 and DomU become completely unresponsive. No error or kernel message is printed in the serial console. Thanks for providing some logs. See some

Re: [PATCH 5.10] xen/events: close evtchn after mapping cleanup

2024-03-04 Thread Andrew Paniakin
On 04/03/2024, Andrew Panyakin wrote: > On 04/03/2024, Greg KH wrote: > > On Sat, Mar 02, 2024 at 08:03:57AM -0800, Andrew Panyakin wrote: > > > From: Maximilian Heyne > > > > > > Commit fa765c4b4aed2d64266b694520ecb025c862c5a9 upstream > [...] > > Where is the 5.15.y version of this commit? We

[PATCH 5.15] xen/events: close evtchn after mapping cleanup

2024-03-04 Thread Andrew Panyakin
From: Maximilian Heyne Commit fa765c4b4aed2d64266b694520ecb025c862c5a9 upstream shutdown_pirq and startup_pirq are not taking the irq_mapping_update_lock because they can't due to lock inversion. Both are called with the irq_desc->lock being taking. The lock order, however, is first

[ovmf test] 184903: all pass - PUSHED

2024-03-04 Thread osstest service owner
flight 184903 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/184903/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 918288ab5a7c3abe9c58d576ccc0ae32e2c7dea0 baseline version: ovmf

Re: Serious AMD-Vi issue

2024-03-04 Thread Elliott Mitchell
On Mon, Feb 12, 2024 at 03:23:00PM -0800, Elliott Mitchell wrote: > On Thu, Jan 25, 2024 at 12:24:53PM -0800, Elliott Mitchell wrote: > > Apparently this was first noticed with 4.14, but more recently I've been > > able to reproduce the issue: > > > > https://bugs.debian.org/988477 > > > > The

[PATCH 6.1] xen/events: close evtchn after mapping cleanup

2024-03-04 Thread Andrew Panyakin
From: Maximilian Heyne Commit fa765c4b4aed2d64266b694520ecb025c862c5a9 upstream shutdown_pirq and startup_pirq are not taking the irq_mapping_update_lock because they can't due to lock inversion. Both are called with the irq_desc->lock being taking. The lock order, however, is first

[xen-unstable test] 184890: trouble: broken/fail/pass

2024-03-04 Thread osstest service owner
flight 184890 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/184890/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt broken Tests which are

Re: [PATCH 5.10] xen/events: close evtchn after mapping cleanup

2024-03-04 Thread Andrew Panyakin
On 04/03/2024, Greg KH wrote: > On Sat, Mar 02, 2024 at 08:03:57AM -0800, Andrew Panyakin wrote: > > From: Maximilian Heyne > > > > Commit fa765c4b4aed2d64266b694520ecb025c862c5a9 upstream [...] > Where is the 5.15.y version of this commit? We have to have that before > we can take a 5.10.y

Re: [PATCH] xen/common: Do not allocate magic pages 1:1 for direct mapped domains

2024-03-04 Thread Julien Grall
On 01/03/2024 03:03, Henry Wang wrote: Hi Julien, Hi Henry, On 2/28/2024 8:27 PM, Julien Grall wrote: Hi Henry, ...here basically means we want to do the finding of the unused region in toolstack. Since currently what we care about is only a couple of pages instead of the whole memory

[ovmf test] 184899: all pass - PUSHED

2024-03-04 Thread osstest service owner
flight 184899 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/184899/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf bff9815b616669f1cf743e412bcefe22dfb4 baseline version: ovmf

Re: [XEN PATCH 02/10] xen/arm: address some violations of MISRA C Rule 20.7

2024-03-04 Thread Nicola Vetrini
Hi, as the maintainers of this subsystem, would you prefer Jan's version or the one in the patch? Both are fine w.r.t MISRA Rule 20.7 because the macro arguments themselves are parenthesized. --- a/xen/arch/arm/include/asm/vgic-emul.h +++ b/xen/arch/arm/include/asm/vgic-emul.h @@ -6,11

Re: [PATCH 1/2] xen/*/nospec: Provide common versions of evaluate_nospec/block_speculation

2024-03-04 Thread Andrew Cooper
On 04/03/2024 5:40 pm, Julien Grall wrote: > Hi Andrew, > > On 04/03/2024 17:07, Andrew Cooper wrote: >> On 04/03/2024 4:55 pm, Jan Beulich wrote: >>> On 04.03.2024 17:46, Julien Grall wrote: On 04/03/2024 16:41, Jan Beulich wrote: > On 04.03.2024 17:31, Julien Grall wrote: >> On

Re: [PATCH 1/2] xen/*/nospec: Provide common versions of evaluate_nospec/block_speculation

2024-03-04 Thread Julien Grall
Hi Andrew, On 04/03/2024 17:07, Andrew Cooper wrote: On 04/03/2024 4:55 pm, Jan Beulich wrote: On 04.03.2024 17:46, Julien Grall wrote: On 04/03/2024 16:41, Jan Beulich wrote: On 04.03.2024 17:31, Julien Grall wrote: On 04/03/2024 16:10, Andrew Cooper wrote: It is daft to require all

Re: [PATCH 1/2] xen/*/nospec: Provide common versions of evaluate_nospec/block_speculation

2024-03-04 Thread Andrew Cooper
On 04/03/2024 4:55 pm, Jan Beulich wrote: > On 04.03.2024 17:46, Julien Grall wrote: >> On 04/03/2024 16:41, Jan Beulich wrote: >>> On 04.03.2024 17:31, Julien Grall wrote: On 04/03/2024 16:10, Andrew Cooper wrote: > It is daft to require all architectures to provide empty implementations

Re: [PATCH 1/2] xen/*/nospec: Provide common versions of evaluate_nospec/block_speculation

2024-03-04 Thread Jan Beulich
On 04.03.2024 17:46, Julien Grall wrote: > On 04/03/2024 16:41, Jan Beulich wrote: >> On 04.03.2024 17:31, Julien Grall wrote: >>> On 04/03/2024 16:10, Andrew Cooper wrote: It is daft to require all architectures to provide empty implementations of this functionality. >>> >>> Oleksii

Re: [PATCH 1/2] xen/*/nospec: Provide common versions of evaluate_nospec/block_speculation

2024-03-04 Thread Andrew Cooper
On 04/03/2024 4:41 pm, Jan Beulich wrote: > On 04.03.2024 17:31, Julien Grall wrote: >> On 04/03/2024 16:10, Andrew Cooper wrote: >>> It is daft to require all architectures to provide empty implementations of >>> this functionality. >> Oleksii recenlty sent a similar patch [1]. This was pushed

Re: [PATCH 1/2] xen/*/nospec: Provide common versions of evaluate_nospec/block_speculation

2024-03-04 Thread Julien Grall
Hi Jan, On 04/03/2024 16:41, Jan Beulich wrote: On 04.03.2024 17:31, Julien Grall wrote: On 04/03/2024 16:10, Andrew Cooper wrote: It is daft to require all architectures to provide empty implementations of this functionality. Oleksii recenlty sent a similar patch [1]. This was pushed back

Re: [PATCH 1/2] xen/*/nospec: Provide common versions of evaluate_nospec/block_speculation

2024-03-04 Thread Andrew Cooper
On 04/03/2024 4:45 pm, Jan Beulich wrote: > On 04.03.2024 17:10, Andrew Cooper wrote: >> --- a/xen/arch/x86/include/asm/nospec.h >> +++ b/xen/arch/x86/include/asm/nospec.h >> @@ -23,20 +23,20 @@ static always_inline bool barrier_nospec_false(void) >> return false; >> } >> >> -/* Allow to

Re: [PATCH 1/2] xen/*/nospec: Provide common versions of evaluate_nospec/block_speculation

2024-03-04 Thread Jan Beulich
On 04.03.2024 17:10, Andrew Cooper wrote: > --- a/xen/arch/x86/include/asm/nospec.h > +++ b/xen/arch/x86/include/asm/nospec.h > @@ -23,20 +23,20 @@ static always_inline bool barrier_nospec_false(void) > return false; > } > > -/* Allow to protect evaluation of conditionals with respect to

[linux-linus test] 184886: tolerable FAIL - PUSHED

2024-03-04 Thread osstest service owner
flight 184886 linux-linus real [real] flight 184898 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/184886/ http://logs.test-lab.xenproject.org/osstest/logs/184898/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking):

Re: [PATCH 1/2] xen/*/nospec: Provide common versions of evaluate_nospec/block_speculation

2024-03-04 Thread Jan Beulich
On 04.03.2024 17:31, Julien Grall wrote: > On 04/03/2024 16:10, Andrew Cooper wrote: >> It is daft to require all architectures to provide empty implementations of >> this functionality. > > Oleksii recenlty sent a similar patch [1]. This was pushed back because > from naming, it sounds like the

Re: [PATCH v2 2/3] docs/misra/rules.rst: add rule 5.5

2024-03-04 Thread Jan Beulich
On 04.03.2024 16:39, Federico Serafini wrote: > On 04/03/24 15:17, Jan Beulich wrote: >> On 04.03.2024 14:31, Federico Serafini wrote: >>> On 01/03/24 09:06, Jan Beulich wrote: On 01.03.2024 00:28, Stefano Stabellini wrote: > On Wed, 14 Feb 2024, Federico Serafini wrote: >> On

Re: [PATCH 1/2] xen/*/nospec: Provide common versions of evaluate_nospec/block_speculation

2024-03-04 Thread Julien Grall
Hi Andrew, On 04/03/2024 16:10, Andrew Cooper wrote: It is daft to require all architectures to provide empty implementations of this functionality. Oleksii recenlty sent a similar patch [1]. This was pushed back because from naming, it sounds like the helpers ought to be non-empty on every

[PATCH 2/2] xen/nospec: Allow evaluate_nospec() to short circuit constant expressions

2024-03-04 Thread Andrew Cooper
When the compiler can reduce the condition to a constant, it can elide the conditional and one of the basic blocks. However, arch_evaluate_nospec() will still insert speculation protection, despite there being nothing to protect. Allow the speculation protection to be skipped entirely when the

[PATCH 0/2] xen/nospec: Improvements

2024-03-04 Thread Andrew Cooper
Andrew Cooper (2): xen/*/nospec: Provide common versions of evaluate_nospec/block_speculation xen/nospec: Allow evaluate_nospec() to short circuit constant expressions xen/arch/arm/include/asm/nospec.h | 9 xen/arch/ppc/include/asm/nospec.h | 9

[PATCH 1/2] xen/*/nospec: Provide common versions of evaluate_nospec/block_speculation

2024-03-04 Thread Andrew Cooper
It is daft to require all architectures to provide empty implementations of this functionality. Provide evaluate_nospec() and block_speculation() unconditionally in xen/nospec.h with architectures able to opt in by providing suitable arch variants. Rename x86's implementation to the arch_*()

Re: [PATCH v2 2/3] docs/misra/rules.rst: add rule 5.5

2024-03-04 Thread Federico Serafini
On 04/03/24 15:17, Jan Beulich wrote: On 04.03.2024 14:31, Federico Serafini wrote: On 01/03/24 09:06, Jan Beulich wrote: On 01.03.2024 00:28, Stefano Stabellini wrote: On Wed, 14 Feb 2024, Federico Serafini wrote: On 14/02/24 14:15, Jan Beulich wrote: On 14.02.2024 12:27, Federico Serafini

Re: [PATCH v2 2/3] docs/misra/rules.rst: add rule 5.5

2024-03-04 Thread Jan Beulich
On 04.03.2024 14:31, Federico Serafini wrote: > On 01/03/24 09:06, Jan Beulich wrote: >> On 01.03.2024 00:28, Stefano Stabellini wrote: >>> On Wed, 14 Feb 2024, Federico Serafini wrote: On 14/02/24 14:15, Jan Beulich wrote: > On 14.02.2024 12:27, Federico Serafini wrote: >> On

Re: [PATCH v2 2/3] docs/misra/rules.rst: add rule 5.5

2024-03-04 Thread Federico Serafini
On 01/03/24 09:06, Jan Beulich wrote: On 01.03.2024 00:28, Stefano Stabellini wrote: On Wed, 14 Feb 2024, Federico Serafini wrote: On 14/02/24 14:15, Jan Beulich wrote: On 14.02.2024 12:27, Federico Serafini wrote: On 14/02/24 09:28, Jan Beulich wrote: On 13.02.2024 23:33, Stefano

Re: [PATCH] x86/cpu-policy: Fix visibility of HTT/CMP_LEGACY in max policies

2024-03-04 Thread Andrew Cooper
On 04/03/2024 8:42 am, Jan Beulich wrote: > On 01.03.2024 12:28, Andrew Cooper wrote: >> --- a/xen/arch/x86/cpu-policy.c >> +++ b/xen/arch/x86/cpu-policy.c >> @@ -464,6 +464,16 @@ static void __init >> guest_common_max_feature_adjustments(uint32_t *fs) >> raw_cpu_policy.feat.clwb )

[xen-unstable-smoke test] 184891: tolerable all pass - PUSHED

2024-03-04 Thread osstest service owner
flight 184891 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/184891/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-armhf-armhf-xl

Re: [PATCH 5.10] xen/events: close evtchn after mapping cleanup

2024-03-04 Thread Greg KH
On Sat, Mar 02, 2024 at 08:03:57AM -0800, Andrew Panyakin wrote: > From: Maximilian Heyne > > Commit fa765c4b4aed2d64266b694520ecb025c862c5a9 upstream > > shutdown_pirq and startup_pirq are not taking the > irq_mapping_update_lock because they can't due to lock inversion. Both > are called with

Re: [PATCH] hvmloader/PCI: skip huge BARs in certain calculations

2024-03-04 Thread Jan Beulich
On 04.03.2024 11:02, Roger Pau Monné wrote: > On Mon, Mar 04, 2024 at 08:32:22AM +0100, Jan Beulich wrote: >> BARs of size 2Gb and up can't possibly fit below 4Gb: Both the bottom of >> the lower 2Gb range and the top of the higher 2Gb range have special >> purpose. Don't even have them influence

[ovmf test] 184892: all pass - PUSHED

2024-03-04 Thread osstest service owner
flight 184892 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/184892/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 1ae5bee967bffcd6dbbabca913ea3c65d8f09c76 baseline version: ovmf

Re: [PATCH] x86/cpu-policy: Hide x2APIC from PV guests

2024-03-04 Thread Andrew Cooper
On 04/03/2024 8:33 am, Jan Beulich wrote: > On 29.02.2024 23:14, Andrew Cooper wrote: >> PV guests can't write to MSR_APIC_BASE (in order to set EXTD), nor can they >> access any of the x2APIC MSR range. Therefore they mustn't see the x2APIC >> CPUID bit saying that they can. > This argumentation

[ANNOUNCE] Call for agenda items for Community Call

2024-03-04 Thread Kelly Choi
Hi all, Please add your proposed agenda items below. https://cryptpad.fr/pad/#/2/pad/edit/VlIkjPmILf0abDG3j1Wn0091/ If any action items are missing or have been resolved, please add/remove them from the sheet. *CALL LINK: https://meet.jit.si/XenProjectCommunityCall

Re: [PATCH] hvmloader/PCI: skip huge BARs in certain calculations

2024-03-04 Thread Alejandro Vallejo
Hi, On 04/03/2024 07:32, Jan Beulich wrote: > BARs of size 2Gb and up can't possibly fit below 4Gb: Both the bottom of > the lower 2Gb range and the top of the higher 2Gb range have special > purpose. Don't even have them influence whether to (perhaps) relocate > low RAM. > > Reported-by:

Re: Link to the 2023 xen summit schedule is broken

2024-03-04 Thread Kelly Choi
Hi Marek, Try this link, it should show the sessions for 2023. https://xen2023.sched.com/ Many thanks, Kelly Choi Community Manager Xen Project On Sun, Mar 3, 2024 at 3:01 AM Marek Marczykowski-Górecki < marma...@invisiblethingslab.com> wrote: > Hi, > > The link to the last year schedule at

XEN SUMMIT CFP DEADLINE EXTENDED BY 1 WEEK!

2024-03-04 Thread Kelly Choi
Hi everyone, Good news, our CFP deadline for Xen Summit has been extended by one week to Sunday 10th March 2024. Please submit your talks before then! Many thanks, Kelly Choi Community Manager Xen Project On Tue, Feb 27, 2024 at 10:22 AM Kelly Choi wrote: > Hi everyone, > > *Just a

Re: [PATCH] MAINTAINERS: drop AMD SVM and Intel VT-x sections

2024-03-04 Thread Roger Pau Monné
On Mon, Mar 04, 2024 at 10:27:44AM +0100, Jan Beulich wrote: > We'd like to thank the VT-x maintainers for their past contributions, > while at the same time we'd like to reflect reality as it has been for > quite some time. Have VT-x maintainership (and for symmetry also AMD > SVM's) fall back to

Re: [PATCH v2] tools/xentop: Add VBD3 support to xentop

2024-03-04 Thread Fouad Hilly
On Tue, Feb 27, 2024 at 6:32 PM Anthony PERARD wrote: > > On Tue, Feb 27, 2024 at 01:26:28PM +, Fouad Hilly wrote: > > diff --git a/tools/libs/stat/xenstat_linux.c > > b/tools/libs/stat/xenstat_linux.c > > index cbba54aa83ee..6d82e204aad4 100644 > > --- a/tools/libs/stat/xenstat_linux.c > >

Re: [XEN PATCH] automation/eclair: add deviation for MISRA C:2012 Rule 16.6

2024-03-04 Thread Federico Serafini
On 04/03/24 11:28, Federico Serafini wrote: Update ECLAIR configuration to take into account the deviations agreed during MISRA meetings. Signed-off-by: Federico Serafini --- Changes in v2: - rephrased to make sure the deviation is not interpreted as a suggestion. ---

[XEN PATCH] automation/eclair: add deviation for MISRA C:2012 Rule 16.6

2024-03-04 Thread Federico Serafini
Update ECLAIR configuration to take into account the deviations agreed during MISRA meetings. Signed-off-by: Federico Serafini --- Changes in v2: - rephrased to make sure the deviation is not interpreted as a suggestion. --- automation/eclair_analysis/ECLAIR/deviations.ecl | 4

Re: [PATCH] hvmloader/PCI: skip huge BARs in certain calculations

2024-03-04 Thread Roger Pau Monné
On Mon, Mar 04, 2024 at 08:32:22AM +0100, Jan Beulich wrote: > BARs of size 2Gb and up can't possibly fit below 4Gb: Both the bottom of > the lower 2Gb range and the top of the higher 2Gb range have special > purpose. Don't even have them influence whether to (perhaps) relocate > low RAM. Here

[ovmf test] 184889: all pass - PUSHED

2024-03-04 Thread osstest service owner
flight 184889 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/184889/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 3775122ede395d934198ffdb0c173875a5e94c00 baseline version: ovmf

Re: [PATCH] MAINTAINERS: drop AMD SVM and Intel VT-x sections

2024-03-04 Thread Andrew Cooper
On 04/03/2024 9:27 am, Jan Beulich wrote: > We'd like to thank the VT-x maintainers for their past contributions, > while at the same time we'd like to reflect reality as it has been for > quite some time. Have VT-x maintainership (and for symmetry also AMD > SVM's) fall back to general x86. > >

Re: [PATCH 5/6] nestedsvm: Remove bogus debug message from nestedsvm_check_intercepts

2024-03-04 Thread George Dunlap
On Tue, Feb 27, 2024 at 12:47 AM Andrew Cooper wrote: > > On 06/02/2024 1:20 am, George Dunlap wrote: > > Changeset ef3e8db8068 ("x86/hvm: Corrections and improvements to > > unhandled vmexit logging") introduced a printk to the default path of > > the switch statement in

Re: [XEN PATCH 08/10] xen/errno: address violations of MISRA C Rule 20.7

2024-03-04 Thread Jan Beulich
On 29.02.2024 16:28, Nicola Vetrini wrote: > MISRA C Rule 20.7 states: "Expressions resulting from the expansion > of macro parameters shall be enclosed in parentheses". Therefore, some > macro definitions should gain additional parentheses to ensure that all > current and future users will be

[PATCH] MAINTAINERS: drop AMD SVM and Intel VT-x sections

2024-03-04 Thread Jan Beulich
We'd like to thank the VT-x maintainers for their past contributions, while at the same time we'd like to reflect reality as it has been for quite some time. Have VT-x maintainership (and for symmetry also AMD SVM's) fall back to general x86. Signed-off-by: Jan Beulich --- a/MAINTAINERS +++

[PATCH 3/3] x86: switch to eager fpu save / restore

2024-03-04 Thread Fouad Hilly
From: Wei Liu Previously FPU is lazily switched. Due to the fact that a malicious guest can speculatively read the not yet switched out register states, we need to eagerly switch FPU states when a domain is scheduled to run. In the new world, Xen will eagerly switch FPU context in the

[PATCH 1/3] x86: i387.c cleanup

2024-03-04 Thread Fouad Hilly
From: Wei Liu No functional change Signed-off-by: Wei Liu Signed-off-by: Fouad Hilly --- CC: Jan Beulich CC: Andrew Cooper CC: "Roger Pau Monné" CC: Wei Liu --- xen/arch/x86/i387.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/i387.c

[PATCH 0/3] X86/eager-fpu: Switch to eager fpu save/restore

2024-03-04 Thread Fouad Hilly
X86 Xen will only eagerly switch FPU context in the scheduler. Xen itslef won't set CR0.TS other than for the purpose of servicing a PV guset. Signed-off-by: Wei Liu Signed-off-by: Roger Pau Monné Signed-off-by: Fouad Hilly --- CC: Jan Beulich CC: Andrew Cooper CC: "Roger Pau Monné" CC: Wei

[PATCH 2/3] x86: introduce xstate_zero

2024-03-04 Thread Fouad Hilly
From: Wei Liu Factor out xrstor__ and introduce xstate_zero, which zeros all the state components specified in the mask. Signed-off-by: Wei Liu Signed-off-by: Fouad Hilly --- CC: Jan Beulich CC: Andrew Cooper CC: "Roger Pau Monné" CC: Wei Liu --- xen/arch/x86/include/asm/xstate.h | 1 +

[PATCH v2 1/1] x86/fred: Fix init_task thread stack pointer initialization

2024-03-04 Thread Xin Li (Intel)
As TOP_OF_KERNEL_STACK_PADDING is defined as 0 on x86_64, no one noticed it's missing in the calculation of the .sp field in INIT_THREAD until it is defined to 16 with CONFIG_X86_FRED=y. Subtract TOP_OF_KERNEL_STACK_PADDING from the .sp field of INIT_THREAD. Fixes: 65c9cc9e2c14 ("x86/fred:

Re: [PATCH] x86/mm: re-implement get_page_light() using an atomic increment

2024-03-04 Thread Jan Beulich
On 04.03.2024 09:50, Roger Pau Monné wrote: > On Mon, Mar 04, 2024 at 08:54:34AM +0100, Jan Beulich wrote: >> On 01.03.2024 13:42, Roger Pau Monne wrote: >>> The current usage of a cmpxchg loop to increase the value of page count is >>> not >>> optimal on amd64, as there's already an instruction

Re: [PATCH] x86/mm: re-implement get_page_light() using an atomic increment

2024-03-04 Thread Roger Pau Monné
On Mon, Mar 04, 2024 at 08:54:34AM +0100, Jan Beulich wrote: > On 01.03.2024 13:42, Roger Pau Monne wrote: > > The current usage of a cmpxchg loop to increase the value of page count is > > not > > optimal on amd64, as there's already an instruction to do an atomic add to a > > 64bit integer. > >

Re: [PATCH] x86/cpu-policy: Fix visibility of HTT/CMP_LEGACY in max policies

2024-03-04 Thread Jan Beulich
On 01.03.2024 12:28, Andrew Cooper wrote: > --- a/xen/arch/x86/cpu-policy.c > +++ b/xen/arch/x86/cpu-policy.c > @@ -464,6 +464,16 @@ static void __init > guest_common_max_feature_adjustments(uint32_t *fs) > raw_cpu_policy.feat.clwb ) > __set_bit(X86_FEATURE_CLWB, fs); >

Re: [PATCH] x86/cpu-policy: Hide x2APIC from PV guests

2024-03-04 Thread Jan Beulich
On 29.02.2024 23:14, Andrew Cooper wrote: > PV guests can't write to MSR_APIC_BASE (in order to set EXTD), nor can they > access any of the x2APIC MSR range. Therefore they mustn't see the x2APIC > CPUID bit saying that they can. This argumentation could then be used equally for the APIC bit.

Re: [XEN PATCH] automation/eclair: add deviation for MISRA C:2012 Rule 16.6

2024-03-04 Thread Federico Serafini
On 04/03/24 09:04, Jan Beulich wrote: On 01.03.2024 16:04, Federico Serafini wrote: --- a/docs/misra/deviations.rst +++ b/docs/misra/deviations.rst @@ -322,6 +322,12 @@ Deviations related to MISRA C:2012 Rules: - /\* Fallthrough \*/ - /\* Fallthrough. \*/ + * - R16.6

Re: Xen 4.19 release status tracking list [ March ]

2024-03-04 Thread Jan Beulich
On 01.03.2024 18:21, Oleksii wrote: > * limit passing around of cpu_user_regs [ > https://lore.kernel.org/xen-devel/ebc330a9-eafa-4858-b5cf-5694c4da9...@suse.com/ > ]: > new patch series version was sent. This was committed already a while ago. > * [PATCH v2 0/5] xen/livepatch: fixes for

Re: [XEN PATCH] automation/eclair: add deviation for MISRA C:2012 Rule 16.6

2024-03-04 Thread Jan Beulich
On 01.03.2024 16:04, Federico Serafini wrote: > --- a/docs/misra/deviations.rst > +++ b/docs/misra/deviations.rst > @@ -322,6 +322,12 @@ Deviations related to MISRA C:2012 Rules: > - /\* Fallthrough \*/ > - /\* Fallthrough. \*/ > > + * - R16.6 > + - A switch statement

Re: [XEN PATCH 10/10] xen/keyhandler: address violations of MISRA C Rule 20.7

2024-03-04 Thread Jan Beulich
On 02.03.2024 02:37, Stefano Stabellini wrote: > On Fri, 1 Mar 2024, Jan Beulich wrote: >> On 29.02.2024 23:57, Stefano Stabellini wrote: >>> On Thu, 29 Feb 2024, Nicola Vetrini wrote: MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be