On 05/03/2024 3:43 pm, Jan Beulich wrote: > On 05.03.2024 16:15, Oleksii wrote: >> I agree that upon examining the current state of the code around these >> functions, it appears safe to provide stubs. However, the reason my >> patch was rejected is that it may not be entirely safe, as Julien >> pointed out that even with Arm, some functions shouldn't be empty. >> >> What I would like to propose is that it might be beneficial, at least >> in CONFIG_DEBUG=y, to have a warning message. Does that make sense? > A warning message to what effect? And are you thinking of a build-time > warning, or a runtime one? Plus wouldn't different aspects quickly lead > to proliferation of warnings?
Putting in a warning for something like this is specifically a bad idea. All it will do is cause people to ignore warnings, and that's the very worst thing Xen could do. ~Andrew
