On 09/12/15 02:12, Jim Graham wrote:
Hi Laurent,
If this were testing a bug that crossed a number of implementation
boundaries such that any number of engineers might make a change that
could cause it to fail, then I might agree with the need to run it
whenever any automated run of tests occurs.
But, the only thing that will cause this to fail would be if someone
modified Marlin - which is basically you, and maybe 1 or 2 other
engineers who would only go in for mostly logistical coding reasons, not
for any changes that might affect the algorithm. Those engineers should
be running the tests with the -manual option specified for testing their
changes.
But, if someone changes some code in core libs, or Swing, or somewhere
else not related to Marlin - you've just added 30 seconds to the amount
of time that it takes them to test for any regressions. Is that
appropriate?
My opinion yes. I doubt that someone will try to run manual
tests(especially in case of future backports). The things which can be
done automatically should be done in this way. Note that core libs team
will not be affected because the jtreg now have a TEST.groups which
allow run the test for one specific area like jdk_math, jdk_nio,
jdk_lang, jdk_desktop etc.(the full list is in the jdk/test/TEST.groups)
I am not sure, but should these tests be marlin specific? I do not see
that they have some marlin specific options and they can cover
other(old/future) renders as well.
...jim
On 12/7/15 11:54 PM, Laurent Bourgès wrote:
Jim,
This test is the most important for Marlin as it checks off-heap array
overflows to detect possible SEG FAULT (critical) so I really want it to
be run automatically to detect a possible regression asap.
I could add the jtreg timeout tag if you want ~ 120s (x4 typical time).
Laurent
Le 8 déc. 2015 03:17, "Jim Graham" <james.gra...@oracle.com
<mailto:james.gra...@oracle.com>> a écrit :
Prior to pushing it I ran the test and it takes over 30 seconds to
complete. Is this something we want to make a manual test?
...jim
On 12/4/15 2:57 PM, Phil Race wrote:
Looks good.
-phil.
On 12/04/2015 02:55 PM, Jim Graham wrote:
Looks good to me. Are jigsaw issues good Phil?
...jim
On 12/3/15 12:58 PM, Laurent Bourgès wrote:
Phil,
If you were to run this on a jigsaw EA build it would fail due to
accessing
sun.java2d.pipe.RenderingEngine. I know this is "pre-existing"
but
jigsaw is coming ...
You're right, sorry !
Here is a new webrev:
http://cr.openjdk.java.net/~lbourges/marlin/marlin-8144446.1/
Changes:
- set System property "sun.java2d.renderer.verbose" to true (to
get the
renderer in use)
- removed any RenderingEngine usage
Laurent
--
Best regards, Sergey.
