Hi Jay, Thanks for investigating this. I add that TIFFImageMetadata.addShortOrLongField() should similarly be changed.
Thanks, Brian On Nov 15, 2016, at 10:12 PM, Jayathirth D V <jayathirth....@oracle.com> wrote: > Present change of having long value as second argument is fine because we > support usage of TIFFTag.TIFF_LONG data type in the constructor. > > I was checking for call hierarchy of this particular constructor from within > JDK9. Most of the calls to this constructor are using either short or int > value for second argument. > > In “public void addShortOrLongField(int tagNumber, int value)“ of > TIFFImageMetadata.java also we are calling this constructor. I think we > should change addShortOrLongField() signature also to use long value for > second argument, because we should support usage of TIFFTag.TIFF_LONG data > type from addShortOrLongField(). > > Please let me know your inputs.