Hi Jay,
Thanks for the review. It would be helpful to get a second review so I can file
a CCC request because of the TIFFField constructor signature change.
Thanks,
Brian
On Nov 16, 2016, at 8:59 PM, Jayathirth D V <jayathirth....@oracle.com> wrote:
> Hi Brain,
>
> Changes are fine.
>
> Thanks,
> Jay
>
> From: Brian Burkhalter
> Sent: Thursday, November 17, 2016 1:53 AM
> To: 2d-dev
> Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-8169725: cannot use
> TIFFField(TIFFTag tag, int value) for TIFF_LONG values greater than
> Integer.MAX_VALUE
>
> Here’s an updated version of the proposed changes.
>
> Thanks,
>
> Brian
>
> ---
> a/src/java.desktop/share/classes/com/sun/imageio/plugins/tiff/TIFFImageMetadata.java
> +++
> b/src/java.desktop/share/classes/com/sun/imageio/plugins/tiff/TIFFImageMetadata.java
> @@ -87,7 +87,7 @@
> rootIFD.initialize(stream, true, ignoreUnknownFields);
> }
>
> - public void addShortOrLongField(int tagNumber, int value) {
> + public void addShortOrLongField(int tagNumber, long value) {
> TIFFField field = new TIFFField(rootIFD.getTag(tagNumber), value);
> rootIFD.addTIFFField(field);
> }
>
> --- a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/TIFFField.java
> +++ b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/TIFFField.java
> @@ -672,7 +672,7 @@
> * for the supplied {@code TIFFTag}.
> * @throws IllegalArgumentException if {@code value < 0}.
> */
> - public TIFFField(TIFFTag tag, int value) {
> + public TIFFField(TIFFTag tag, long value) {
> if(tag == null) {
> throw new NullPointerException("tag == null!");
> }
>
> On Nov 16, 2016, at 8:20 AM, Brian Burkhalter <brian.burkhal...@oracle.com>
> wrote:
>
>
> Thanks for investigating this. I agree that
> TIFFImageMetadata.addShortOrLongField() should similarly be changed.
