On Tue, 1 Dec 2020 19:38:37 GMT, Sergey Bylokhov <[email protected]> wrote:
>> Approved.
>> Whilst the fix looks reasonable and important for on-screen, I am surprised
>> it was an issue when printing.
>> At *printer resolution* it is really surprising that there are any bitmaps
>> for the glyphs.
>> We should be talking about a 300 dpi printer minimum these days and so we
>> should be requesting at least 50 pixel
>> high text for even 12pt nomimal size. Fonts usually don't have bitmaps at
>> that size because they are large and less important.
>> So I am not sure under what circumstances you saw it.
>>
>> Secondly, I think that unless we were going down the raster path (which I
>> think you said we were) that we normally explicitly used filled shapes for
>> CJK.
>
> The testing is in progress.
The new test fails on the headless macs(I cannot reproduce it on my laptop):
----------System.out:(1/17)----------
ErrorCount:53,53
----------System.err:(13/1055)----------
java.lang.RuntimeException: Incorrect mirrored character with
java.awt.Font[family=AppleMyungjo,name=AppleMyungjo,style=plain,size=12]
at MirrorTest.main(MirrorTest.java:147)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:567)
at
com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
at java.base/java.lang.Thread.run(Thread.java:831)
Do we need to mark it as headful, or it might be a product bug?
-------------
PR: https://git.openjdk.java.net/jdk/pull/1218
