On Wed, 30 Jun 2021 10:42:44 GMT, Maxim Kartashev <github.com+28651297+mkartas...@openjdk.org> wrote:
>> Added an `ExceptionCheck()` followed by `ExceptionDescribe()` and >> `ExceptionClear()` immediately after the Java calls made from the callback >> function `ReadTTFontFileFunc()` in `freetypeScaler.c`. >> >> The exception(s) need to be cleared because we're not returning immediately >> to Java that would've been able to handle them gracefully. And in order not >> to loose the exception entirely (even though the return value would also >> indicate an error condition), print out the exception with >> `ExceptionDescribe()` to aid in debugging. > > Maxim Kartashev has updated the pull request incrementally with one > additional commit since the last revision: > > Addressed PR comments > > 1. Allowed test to run on any platform. > 2. Trimmed comments to fit in with 80 columns. > 3. Removed unnecessayr comments. > 4. Made the ExceptionDescribe() calls conditional on the value of > FontUtilities.debugFonts() Looks fine to me, I'll run the tests. ------------- PR: https://git.openjdk.java.net/jdk/pull/4572
