On Sat, 17 Jul 2021 03:03:41 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:
>> Maxim Kartashev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 1. Marked the test as headful so that it doesn't fail on a headless >> system. >> 2. Added exception checks to Windows-specific code. > > src/java.desktop/windows/native/libawt/java2d/d3d/D3DRenderQueue.cpp line 870: > >> 868: J2dTraceLn(J2D_TRACE_VERBOSE, " executing runnable"); >> 869: jboolean ignoreException; >> 870: JNU_CallMethodByName(env, &ignoreException, pFlush->runnable, >> "run", "()V"); > > What is the purpose of this change? the only difference is that in the second > case the ExceptionCheck will be called, does it affect something? Yes, the `ExceptionCheck()` call will silence the warnings from `-Xcheck:jni`. ------------- PR: https://git.openjdk.java.net/jdk/pull/4572