> You call __asan_report_load8 directly.
> This will only work if __asan_load8 does not have its own frame.

You mean you don't want asan callbacks to be present in stacktraces?

> My version lacked the UNLIKELY trick. fixed.

Cool, upstream code seems to run really fast now: 16 sec. (vs my 17.8
sec.). Looks like outline overhead is only 300% now (compared to 200%
for normal inline ASan) which is probably acceptable. And we'll have
to work around ABI to improve further.

Some suggestions:
* can we move separate calls for begin/end for intrinsics (and larger
memory accesses) into callbacks ?
* can we remove check for size == 0 and perform it in callback instead ?
I can submit a patch if you are ok with those.

BTW note that we will suffer significant PLT penalty in sanitized shared libs.

-Y

-- 
You received this message because you are subscribed to the Google Groups 
"address-sanitizer" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to address-sanitizer+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to