To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=78198
User aw changed the following:
What |Old value |New value
================================================================================
Assigned to|aw |kendy
--------------------------------------------------------------------------------
Status|STARTED |NEW
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Mon Jun 11 08:47:38 +0000
2007 -------
AW->kendy: For security reasons - especially in old code - i would like to have
changes as minimal as possible. Could You please try to get the stuff running by
just changing FindObject to return a bool and the evtl. found index in a
call-by-reference parameter, e.g.
current: svx\inc\svx\svdmark.hxx(351): sal_uInt32 FindObject(const
SdrObject*
pObj) const;
future: bool FindObject(sal_uInt32 noFoundIndex, const SdrObject* pObj) const;
and the usages (TryToFindMarkedObject, SdrMarkList::FindObject implementation,
svx\source\svdraw\svdmark.cxx(1007), evtl. apps...) of course.
There is nothing against Your patch in general since it is about code which
needs to be reworked soon anyways, but let's keep the risk minimal if possible.
I have already seen changes with small invasive changes triggering errors
because of their broad footprint.
Please try this and tell me about the result, evtl. apply new patch. Thanks in
advance.
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
