To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=108345
------- Additional comments from m...@openoffice.org Thu Apr 22 17:44:01 +0000 2010 ------- @dtardon: just finished looking at the whole patch. good work, this looks like it should (with correction from prev. comment) solve the problem! you even wrote some comment about what the heck the function actually does when it's called with another node! + // 4 a a clear item in this + // 5 a b convert item to attr of this after looking at both versions, i think those are remarkable: in case 4, this is indeed what your patch does, but the old code apparently did nothing. but i don't think this is a problem, because the "this" node is usually deleted afterward anyway. in case 5, what you write is actually what the old code does. your patch seems to convert *both* items to hints, so it should probably read: + // 5 a b convert b to attr of this, a to attr of pNd again, i don't think this is a real difference in practice, because probably the result of the old code was handled correctly by all clients, and the result of your patch is obviously correct. nitpick: + SfxItemSet aConvertSet( pNd->GetDoc()->GetAttrPool(), aCharFmtSetRange ); + aConvertSet.Put(aNdSet); aConvertSet seems unnecessary here, because it's just a copy of aNdSet. why not use that instead? nitpick: + SfxItemSet* m_pAttrSet; could be a reference, right? final nitpick: "orignal" is not a word :) --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org --------------------------------------------------------------------- To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
