To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=108345
------- Additional comments from dtar...@openoffice.org Fri Apr 23 14:42:03 +0000 2010 ------- dtardon->mst: > this here (lcl_CollectHintSpans): > > + if (pHint->IsCharFmtAttr()) > > probably seemed obvious to you, but actually, AUTOFMT hints don't have this > flag > set! Oh, that seemed so obvious I didn't even bother to look up the definition of the function... > in case 5, what you write is actually what the old code does. > your patch seems to convert *both* items to hints, so it should probably read: > + // 5 a b convert b to attr of this, a to attr of > pNd > That was oversight on my side and i've corrected the code to match the comment. > nitpick: > + SfxItemSet aConvertSet( pNd->GetDoc()->GetAttrPool(), > aCharFmtSetRange ); > + aConvertSet.Put(aNdSet); > > aConvertSet seems unnecessary here, because it's just a copy of aNdSet. > why not use that instead? Good point. > nitpick: > + SfxItemSet* m_pAttrSet; > could be a reference, right? Sure, it could. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org --------------------------------------------------------------------- To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
