To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=108345





------- Additional comments from dtar...@openoffice.org Tue Apr 27 05:13:24 
+0000 2010 -------
dtardon->mst:

> this here is completely broken:
> +            std::for_each(aProcessedIds.begin(), aProcessedIds.end(),
> +                    boost::bind(&SfxItemSet::ClearItem, aNdSet, _1));
> 
> apparently the boost::bind creates a copy of the item set, and then calls
> ClearItem on this copy instead of on aNdSet.

Yeah, it does, as all its parameters are passed by value ... and I knew it. No
excuse for me! The right thing here would have been to pass the node set through
boost::ref, i.e.

std::for_each(aProcessedIds.begin(), aProcessedIds.end(),
        boost::bind(&SfxItemSet::ClearItem, boost::ref(aNdSet), _1));

Anyway, thanks for finishing the patch!

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org
For additional commands, e-mail: issues-h...@sw.openoffice.org


---------------------------------------------------------------------
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org

Reply via email to