[Public]

This series is :

Reviewed-by: Yifan Zhang <[email protected]>

-----Original Message-----
From: Alex Deucher <[email protected]>
Sent: Tuesday, January 27, 2026 4:49 AM
To: Deucher, Alexander <[email protected]>
Cc: [email protected]; Zhang, Yifan <[email protected]>
Subject: Re: [PATCH 04/12] drm/amdgpu/gmc9: handle gfxoff in interrupt set 
functions

On Mon, Jan 26, 2026 at 3:1 PM Alex Deucher <[email protected]> wrote:
>

Patch title should say gmc10.  Fixed locally.

Alex

> Need to make sure gfxoff is disallowed when we touch GC registers over
> MMIO.
>
> Cc: Yifan Zhang <[email protected]>
> Signed-off-by: Alex Deucher <[email protected]>
> ---
>  drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
> b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
> index 2568eeaae9454..7a8e86efdfe40 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
> @@ -64,6 +64,7 @@ gmc_v10_0_vm_fault_interrupt_state(struct amdgpu_device 
> *adev,
>                                    struct amdgpu_irq_src *src, unsigned int 
> type,
>                                    enum amdgpu_interrupt_state state)
> {
> +       amdgpu_gfx_off_ctrl(adev, false);
>         switch (state) {
>         case AMDGPU_IRQ_STATE_DISABLE:
>                 /* MM HUB */
> @@ -92,6 +93,7 @@ gmc_v10_0_vm_fault_interrupt_state(struct amdgpu_device 
> *adev,
>         default:
>                 break;
>         }
> +       amdgpu_gfx_off_ctrl(adev, true);
>
>         return 0;
>  }
> --
> 2.52.0
>

Reply via email to