[ 
http://jira.amdatu.org/jira/browse/AMDATU-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=10870#comment-10870
 ] 

Bram de Kruijff commented on AMDATU-282:
----------------------------------------

<quote>
In the new dispatcher a new 'DefaultHttpContext' was introduced, however 
HttpContextImpl is also still used. I'm not sure why there are two HttpContext 
implementations. Also HttpContextImpl uses the Apache Sling Mimetype service 
for mimetype resoving, the DefaultHttpContext doesn't. However, 
HandlerServletContext seems to use the Felix http service for mimetype 
resolving. If we choose to use the mimetype resolving of the Felix http 
service, I would expect the HttpContextImpl to use the same resolver. However, 
it would be best to prevent dependencies with the Felix implementation of the 
http service, such that we can replace it by another http service 
implementation if we want to (ok, we depend on it anyway for filter 
registration, I know).
</quote>

I chose to refactor the current httpcontext module as little as possible 
leaving that up to AMDATU-283 which did not make it in 0.1.0. Note that the 
dispatcher does not use any service for mime type resolving it simply borrows 
the MimeType class from Felix HttpService (actually embeds it). For now it has 
the advantage of guaranteeing that HttpService and Dispacther have the same 
list and it does not threaten future compatibility with any other possible 
HttpServiceimpl. Whether we should standardize on one or the other... not sure. 
I'll leave a comment at  AMDATU-283.


> Integrate web dispatcher project
> --------------------------------
>
>                 Key: AMDATU-282
>                 URL: http://jira.amdatu.org/jira/browse/AMDATU-282
>             Project: Amdatu
>          Issue Type: New Feature
>          Components: Amdatu Web
>    Affects Versions: 0.1.0
>            Reporter: Bram de Kruijff
>            Assignee: Bram de Kruijff
>             Fix For: 0.1.0
>
>
> Implementation and integration of a web dispatcher mechanism that support 
> pluggable (servlet/request) context extenders and tenant aware dispatching to 
> web component. As described at 
> http://lists.amdatu.org/pipermail/amdatu-developers/2011-January/002341.html

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to