[
http://jira.amdatu.org/jira/browse/AMDATU-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=10879#comment-10879
]
Ivo Ladage - van Doorn commented on AMDATU-282:
-----------------------------------------------
Regarding:
<quote>
In the new dispatcher a new 'DefaultHttpContext' was introduced, however
HttpContextImpl is also still used. ...
</quote>
Ok to leave it like this for now
Regarding
<quote>
I have concerns regarding the design of the way dependencies between ...
</quote>
I still believe some refactoring would be appropriate, but I agree that this is
not blocking for 0.1.0 so we can leave it like this for now.
What about these other issues; ?
- AbstractHandler lines 70-72 contain unnecessary casts as the map is already
typed <String, String>
- In AbstractHandlerRegistry line 104 a new DefaultHttpContext is returned when
the service reference has no contextId property. So this method returns a
different instance each time it is invoked for the same ServiceReference. I'm
not sure if that is the intention.
- In DispatcherServiceActivator the LogService is defined as a required
dependency, but the DispatcherServiceImpl checks if the LogService is null
before using it (sometimes and sometimes not).
- In DispatcherServiceImpl line 92 ServletException is rethrown as Exception,
why?
> Integrate web dispatcher project
> --------------------------------
>
> Key: AMDATU-282
> URL: http://jira.amdatu.org/jira/browse/AMDATU-282
> Project: Amdatu
> Issue Type: New Feature
> Components: Amdatu Web
> Affects Versions: 0.1.0
> Reporter: Bram de Kruijff
> Assignee: Ivo Ladage - van Doorn
> Fix For: 0.1.0
>
>
> Implementation and integration of a web dispatcher mechanism that support
> pluggable (servlet/request) context extenders and tenant aware dispatching to
> web component. As described at
> http://lists.amdatu.org/pipermail/amdatu-developers/2011-January/002341.html
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
