[
http://jira.amdatu.org/jira/browse/AMDATU-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=10872#comment-10872
]
Bram de Kruijff commented on AMDATU-282:
----------------------------------------
<quote>
I have concerns regarding the design of the way dependencies between the
DispatcherServiceImpl, ServletHandlerRegistry, FilterHandlerRegistry and
DispatchInterceptFilter are setup. The DispatcherServiceImpl is the one and
only actual service, other components like the servlet and filter handler
registry are instantiated from the DispatcherServiceImpl. There are cross
references between them, for example the DispatcherServiceImpl references the
DispatchInterceptFilter and the DispatchInterceptFilter references the
DispatcherServiceImpl. Also other service dependencies like the LogService are
passed from the constructor instead of using service dependencies. Why are
those classes not implemented as services? I guess the cross-references between
them makes that hard, but I believe this needs some refactoring such that all
those components are actual services using proper service dependencies.</quote>
On the make everything a service part I disagree as these are implementation
details. Dispatcher is the only business service api I am exposing (and that I
whish to expose). It is true that this now all depends on the fact that the
collaborators are managed within the Dispatcher lifecycle. Eg. changing
LogService dependency to non required would require me to reset those members
on my collaborators... using dependency manager composition support may be a
better option.
> Integrate web dispatcher project
> --------------------------------
>
> Key: AMDATU-282
> URL: http://jira.amdatu.org/jira/browse/AMDATU-282
> Project: Amdatu
> Issue Type: New Feature
> Components: Amdatu Web
> Affects Versions: 0.1.0
> Reporter: Bram de Kruijff
> Assignee: Bram de Kruijff
> Fix For: 0.1.0
>
>
> Implementation and integration of a web dispatcher mechanism that support
> pluggable (servlet/request) context extenders and tenant aware dispatching to
> web component. As described at
> http://lists.amdatu.org/pipermail/amdatu-developers/2011-January/002341.html
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
