[ 
http://jira.amdatu.org/jira/browse/AMDATU-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12194#comment-12194
 ] 

Marcel Offermans commented on AMDATU-493:
-----------------------------------------

Regarding:

1) I agree scoping service properties to make them Amdatu specific makes sense. 
The OSGi spec (core, 5.2.5) already reserves some namespaces, and I would 
suggest the safest namespace for us to claim is org.amdatu.*

I am hesitant to define more than just an ID and a name for a tenant. Like 
mentioned in the issue regarding the code, a hostname is only used in a 
specific scenario, so it should not be part of the default set of properties. 
However, I do think we should be extensible here (see 3)).

2) Again, I agree that a we should formalize this. The spec addresses custom 
headers in 3.2.2 and suggests we either prefix all of them with "x-" (and then 
probably append some Amdatu specific prefix) or register them here (see 
http://www.osgi.org/Specifications/ReferenceHeaders). I'm not sure if we can 
claim a whole namespace that way though. If we can, let's claim "Amdatu-\*". 
Otherwise, I would suggest going with "x-Amdatu-\*".

3) I think we should support associating "extra" properties with tenants. In 
the Tenant API I would only expose a minimal, read-only view. We can achieve 
that either by exposing extra properties as service properties, or via a 
String[] getPropertyKeys()/getProperty(String key) like API. I would only do 
the latter if we must, but I have a strong feeling that just exposing them as 
service properties is enough.

4) I can see what you mean, and we should use consistent naming. We have a 
feature called "multi-tenancy support". It is optional, so if you do not use 
it, I would not mention anything related to a "tenant". If you do use it, since 
one of our requirements is to make it transparent to the developer, in 80% of 
the cases you probably never mention it either. Only when implementing a bundle 
that has a specialized/optimized handling of tenants do you need to get 
explicit. The other case is when deploying an application in a multi-tenant 
configuration. So, I would never mention "single-tenancy", but instead just 
talk about the OSGi container and the application you're deploying in it.
                
> Document Multi-Tenancy design
> -----------------------------
>
>                 Key: AMDATU-493
>                 URL: http://jira.amdatu.org/jira/browse/AMDATU-493
>             Project: Amdatu
>          Issue Type: Sub-task
>            Reporter: Bram de Kruijff
>            Assignee: Marcel Offermans
>             Fix For: Sprint 1
>
>
> Finalize Multi-Tenancy mechanism design [0]
> [0] http://www.amdatu.org/confluence/display/Amdatu/Amdatu+Core+Tenant+Design

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
http://jira.amdatu.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
_______________________________________________
Amdatu-developers mailing list
[email protected]
http://lists.amdatu.org/mailman/listinfo/amdatu-developers

Reply via email to