I must admit that was misleading, we had reports of abg cards working
at the same time so i started looking all the way on PHY related stuff
and i missed that ;-)

Anyway the real fix for this is coming (channel flags are not handled
correctly, that was the bug, in the code CHANNEL_B and CHANNEL_G are
not the right flags to check because they both contain CHANNEL_2GHZ so
if we AND our current 2GHz channel with any of them it'll return true
and that's BAD. Also a check between a CHANNEL_G and a CHANNEL_A would
also return true because they contain CHANNEL_OFDM flag).

Also today i got a 5414 to play with and hope i'll get some results soon ;-)

2007/11/5, Luis R. Rodriguez <[EMAIL PROTECTED]>:
> On 11/5/07, Evgeni Golov <[EMAIL PROTECTED]> wrote:
> > On Mon, 5 Nov 2007 18:18:05 +0200 Nick Kossifidis wrote:
> >
> > > Other ppl with b/g only cards have the same result ???
> >
> > Just for the record, git bisect says, it was the following commit:
> >
> > commit a4652a02120b518f0399440178f575802a690758
> > Author: Luis R. Rodriguez <[EMAIL PROTECTED]>
> > Date:   Thu Nov 1 17:50:30 2007 -0400
> >
> >     ath5k: Clean up ath5k rate duration settings
> >
> > Which enabled bg only for me?!
> > However, I dunno why :)
>
> Yeah that commit didn't do much. The real fix should have been through
> the commit below. The problem before was we were setting eeprom mode
> to B instead of G. Perhaps the rate durations were messed up as well
> though. So anyway, glad it works. I've just tested another BG card and
> am writing online with it. Its
>
> ath5k_pci 0000:15:00.0: Atheros AR5213A chip found: MAC 0x59, PHY: 0x43
> ath5k_pci 0000:15:00.0: RF2112A radio found (0x46)
>
> "AT&T Plug & Share Wirelses Notebook Adapter"
>
> Author: Luis R. Rodriguez <[EMAIL PROTECTED]>
> Date:   Thu Nov 1 00:34:24 2007 -0400
>
>     ath5k: Fix initval/eeprom/IQ calibration for G mode
>
>     ath5k_hw_reset() was always setting initval and eeprom settings for B mode
>     when using G mode. This is because a B channel was being picked up first. 
> We
>     should first instead check for G channel. This patch also introduces a
>     driver_mode variable which should be used instead for determing
>     more reliably the mode we're in.
>
>     This fixing another bug where IQ calibration was not being run for
>     G mode as CHANNEL_B was always being picked up first. We now instead
>     check for driver_mode.
>
>     Similar problem was occurring in ath5k_hw_rf5112_rfregs(), we fix this
>     there too.
>
>     Changes to phy.c, hw.c
>     Changes-licensed-under: ISC
>
>     Signed-off-by: Luis R. Rodriguez <[EMAIL PROTECTED]>
>     Signed-off-by: John W. Linville <[EMAIL PROTECTED]>
> _______________________________________________
> ath5k-devel mailing list
> ath5k-devel@lists.ath5k.org
> https://lists.ath5k.org/mailman/listinfo/ath5k-devel
>


-- 
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick
_______________________________________________
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel

Reply via email to