On Sat, 2008-12-13 at 09:24 -0500, Bob Copeland wrote: > [trimmed a couple of lists from CC] > > On Sat, Dec 13, 2008 at 03:28:24PM +0200, Maxim Levitsky wrote: > > > i think that some led settings are stored on EEPROM, let me check it > > > out... > > > > Indeed gpio #3 controls the led. > > I patched ath5k to use it, and led works now fine. > > BTW I looked for settings in EEPROM and didn't find any. Then maybe create a whitelist of vendors vs gpio numbers? Also a module param to set the gpio pin won't hurt.
> > > What I dislike is the way led blinks: > > This is something that should rather change in mac80211, I think. It > just toggles the state on every packet, and we just do the same when > mac80211 says so (ath5k *could* set up timers like b43, but it's a > lot of extra code, and every driver shouldn't have to do so.) > IWL3945 sets timers too, and this does look ugly. Also I noticed that sometimes led state gets inverted and it stuck until I reload the module. Best regards, Maxim Levitsky _______________________________________________ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel