On Sat, 2010-06-19 at 08:38 -0400, Bob Copeland wrote:
> On Sat, Jun 19, 2010 at 10:49:34AM +0300, Maxim Levitsky wrote:
> > How this patch?
>
> Looks fine to me. Some nitpicking below but feel free to add my
>
> Acked-by: Bob Copeland <m...@bobcopeland.com>
>
> to this or a later version.
>
> > Signed-off-by: Jussi Kivilinna <jussi.kivili...@mbnet.fi>
> > Signed-off-by: Maxim Levitsky <maximlevit...@gmail.com>
>
> I believe maintaining the s-o-b is usually reserved for the case when the
> patch only has minor edits; here your patch while same in spirit has
> some 30 fewer lines. Maybe should use "From:" or mention Jussi in the
> commit log to maintain attribution instead?
OK
>
> > + /* Disable PCIE ASPM L0S. It is never enabled by windows driver */
> > + pci_disable_link_state(pdev, PCIE_LINK_STATE_L0S);
> > +
>
> Would be good to expand this comment as to why (just copy another
> sentence from the commit log or so).
OK
>
> > ret = pci_enable_device(pdev);
> > if (ret) {
> > dev_err(&pdev->dev, "can't enable device\n");
> > @@ -722,6 +726,8 @@ static int ath5k_pci_resume(struct device *dev)
> > struct ieee80211_hw *hw = pci_get_drvdata(pdev);
> > struct ath5k_softc *sc = hw->priv;
> >
> > + pci_disable_link_state(pdev, PCIE_LINK_STATE_L0S);
> > +
>
> Did you test that it did get lost over suspend/resume? A glance at
> pci_save_pcie_state seems to indicate it's saved.
Will test.
Best regards,
Maxim Levitsky
_______________________________________________
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
