Hi Al, >>>>> Al Haji-Ali <[email protected]> writes: > Thanks for this. Embarrassingly, I had some changes that I somehow > failed to push to the repo. Hence the discrepancy between our > experiences. > My apologies for the confusion, please pull the changes which should > have everything fixed now.
Thank you, now it works fine. > I still don't see this one. But maybe with the fix I pushed it will > work out anyways? OK, now it just shows "Do not enter" sign, which persits even when I move the cursor out of the math expression in question. > Apologies. I just checked and it was a copy-paste mistake in the > original example. I see, don't mind. > I plan two other commits: > - One to implement dvisvgm in preview.el: My approach will be to > re-use the code of dvipng, but allow `preview-dvipng-command` to be > a function so that it can construct the command of `dvisvgm`. There > is a lot of code duplication in preview.el between dvips and dvipng, > and adding dvisvgm would duplicate even more code, unless we > refactor the code like I do in preview-point which would introduce > some significant changes. Let me know what you think. Sounds nice. Code refactorization will be benefitical for further extention in future. > - Another commit to add preview-point and buframe. Not sure how to > - include these (as separate files or part of preview.el). As Arash said before, buframe would be useful as a separate library, so it should be a separate file. (You can even consider to submit it as an independent package to ELPA.) I think preview-point can be merged into preview.el, but nothing is wrong to have it as a separate file. I'm neutral about it. Regards, Ikumi Keita #StandWithUkraine #StopWarInUkraine #Gaza #StopMassiveKilling #CeasefireNOW
