Ikumi Keita <[email protected]> writes: >>>>>> Al Haji-Ali <[email protected]> writes: >> >> I plan two other commits: >> - One to implement dvisvgm in preview.el: My approach will be to >> re-use the code of dvipng, but allow `preview-dvipng-command` to be >> a function so that it can construct the command of `dvisvgm`. There >> is a lot of code duplication in preview.el between dvips and dvipng, >> and adding dvisvgm would duplicate even more code, unless we >> refactor the code like I do in preview-point which would introduce >> some significant changes. Let me know what you think. > > Sounds nice. Code refactorization will be benefitical for further > extention in future.
👍 >> - Another commit to add preview-point and buframe. Not sure how to >> - include these (as separate files or part of preview.el). > > As Arash said before, buframe would be useful as a separate library, so > it should be a separate file. (You can even consider to submit it as an > independent package to ELPA.) Until now, AUCTeX doesn't have any Emacs external dependencies; my gut feeling is to keep it that way, i.e., bundle buframe.el with AUCTeX and not as an ELPA package. It is probably easier for distros to offer AUCTeX as a package. > I think preview-point can be merged into preview.el, but nothing is > wrong to have it as a separate file. I'm neutral about it. Same here. My only wish is to make the entry point of this feature easier for users than how it is right now. Best, Arash
