Hi Al,

Al Haji-Ali <[email protected]> writes:

> I've implemented this idea (not requiring buframe until used). There's
> one helper function that is specific to buframe
> `preview-point--buframe` which uses four functions from the package,
> and which are declared with arguments right before the definition of
> the helper.

Since we now plan to have buframe.el as an external package, the declare
part should read:

  (declare-function buframe-position-right-of-overlay "ext:buframe"
                    (frame ov &optional location))

Note the "ext:" part which can be important, I think.  From the
docstring:

  A FILE with an "ext:" prefix is an external file.
  ‘check-declare’ will check such files if they are found, and skip
  them without error if they are not.

> I concur that it's not the most elegant solution and I will need
> advice on where to put appropriate documentation. I've kept buframe in
> the repo for now. I will send it to ELPA soon, after I get feedback on
> preview-point here.

Which feedback is still pending?  At any rate, for the way forward I
suggest you take the current state you have and send 6 distinct
format-patch change sets (each as one bug report) to AUCTeX bug-tracker.
Then we can do a final review if needed and start installing them.  I
think that will help us reach more users who start AUCTeX from a repo or
install from ELPA-devel.  We can then decide which documentation we have
to tweak.  Does this make sense?

> PS: Any idea why preview.el is in .gitignore?

I'd say a leftover from the time when we had preview.el.in from which
preview.el was generated.  I think we can delete that entry now.  Keita?

Best, Arash

Reply via email to