-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 30.07.2010 17:54, Ignas Anikevicius wrote: > Hello everybody, > > It seems that the question of dyn tagging in awesome is getting a bit > rusty... :) I have corrected the patch according to Ulis wishes, so > maybe it will be better? > > On 13/07/10 19:08, Uli Schlachter wrote: >> What if fallback_tag == nil and the client is not sticky? It won't be >> attached >> to any tags after this. >> >> Which makes me wonder... Can that happen at all? The only way for >> fallback_tag >> to be nil is because find_fallback() found nothing. This can only happen if >> there is no other tag on this screen, but there was an "if" above which >> checked >> for this already, no? > I think, that everything should be good. Although it is not very nice to > have a test in different functions, so I made it thrice bullet proof. :) > I guess it should be good. > > Tell me if it is otherwise (It is my first contribution, although very > small, so I am happy to receive any critics or suggestions). > > Cheers, > Ignas A. (gns_ank)
Hi, I tried merging your patch: $ git am -s /tmp/1.patch Patch format detection failed. Looking more closely at the file, I noticed that it's the output of "git show". Could you instead send us a file from "git format-patch"? "git format-patch HEAD^.." should do the trick. Cheers, Uli - -- - - Buck, when, exactly, did you lose your mind? - - Three months ago. I woke up one morning married to a pineapple. An ugly pineapple... But I loved her! -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQEcBAEBCAAGBQJMVwE8AAoJECLkKOvLj8sGmDcH/ibIhs8MP96asw54ZZdPspZ6 ML0o0sayL7jhZUisU+bGX/5QA9OpNvGYl0p7GrIXr32haYvjD6afrkk9INYQ2YAw XuKTj5lkKrrpNzl8zA0p84AHKy4IF3gxdj0nisTqsk83VKKt+hq/lxDqPRuPKib0 M/Too62mA83ieOIihqmHh9MnfniHFa/RNWt1RkrR3JQb66t3oBbTu8aEe/c6G+8c Mitvq7jVGxnJzLrOAvP+gl4FwZvBXaBSyZqbO03QXecbRYQ6UxeJ6/dGS4W1GVO3 DUNKQ7uBFO4UH42AZObaCw4XXpF9XrtHeoAFWxYmcbI9W2pRQ+JOlIkw+NH4O2g= =9kdV -----END PGP SIGNATURE----- -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.
