Morning, On 04.03.2012 10:41, Anurag Priyam wrote: > On Fri, Mar 2, 2012 at 1:20 PM, Uli Schlachter <psyc...@znc.in> wrote: >> However, I successfully started a program with the prompt (via pressing enter >> and all that) and still had this problem. This is the part which I still >> don't >> understand. > > I can't reproduce it.
I can't reproduce it anymore either. WTF? >>> awful.prompt is quite messy that way: a giant (>200 lines) of >>> callback to `keygrabber.run` with too many return true and false. >> >> The "return true" would just be replaced by "return" and I only count a >> single >> "return false". I don't say this code is great, but the patch wouldn't be all >> that bad. > > Hmm. I gave it a shot but it there still remains a glitch (see 2nd patch): > > When I close the prompt, either by executing a command or by pressing > 'Escape, the keygrabber stops but the prompt with its text remains > stuck up there :-/. I haven't verified it, but I think I know what might be wrong (see below) [...] >> I'm playing my usual "sorry, no time to code this myself"-card and return to >> doing non-awesome stuff. (Yes, I do mean both meanings of this sentence) > > What else takes up your time? Just curious. College? Job? Apart > from my undegrad studies, I work on some Comp. Bio. stuff when I get > time. University wants me to finish a presentation till tomorrow, but when I wrote that lines, I think I was trying to debug an issue in cairo (and failed :-( ). Now the patch: First one is merged, second one conflicts with a change that I did at the same moment that you sent your mail. And somehow I can't convince git to let me mess with that conflict. However, the second patch doesn't convince me: Please don't remove any return statements, but replace them with "return" (unless at the end of the function). There are three such changes in the patch. Uli -- - Captain, I think I should tell you I've never actually landed a starship before. - That's all right, Lieutenant, neither have I. -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.
