Hi Costantino,
src/solaris/classes/sun/awt/UNIXToolkit.java:
the indentation is incorrect.
src/solaris/classes/sun/awt/X11/GtkFileDialogPeer.java
The copyright notice at the top should be dated 2010. That file hasn't
existed in 1995 for sure.
src/solaris/native/sun/awt/sun_awt_X11_GtkFileDialogPeer.c
Generally the file uses incorrect indentation...
26 return (*env)->CallBooleanMethod(env, obj,
filenameFilterCallbackMethodID,
27 filename);
Perhaps that makes sense to explicitly cast the return value to gboolean
to avoid any compilation warnings.
Also, I second to Damjan regarding the placement of variable
declarations. In C they have to be in the beginning of a function.
The rest looks good.
--
best regards,
Anthony
On 03/01/2010 02:52 PM, Costantino Cerbo wrote:
Hello Anthony, Hello Peter,
what about my patch for the issue 6913179?
Did you start the review?
I report again the most relevant changes:
1. Dynamic link to libgthread-2.0.so.0 instead of libgthread-2.0.so
2. GTK multithread support (gdk_threads_enter() and
gdk_threads_leave() as outlined by Damjan)
3. New Thread to don't block the EDT
4. Support for multiple file selection (bugs 6705345)
Best regards,
Costantino
2010/2/19 Anthony Petrov <[email protected]>:
Hi Costantino,
Here's the latest version of your fix:
http://cr.openjdk.java.net/~anthony/7-43-GTKFileDialog-6913179.3/
Thanks!
Okay, but meanwhile we can open an issue for this feature in the Sun
bug database, what do you think about?
Just filed the following:
6927978 : Directory Selection standard dialog support
(should become visible on the bugs.sun.com in a day or two).
--
best regards,
Anthony
