Hello Damjan, 2010/3/10 Damjan Jovanovic <[email protected]>: > You should probably include the real header files here, like string.h > and jni_util.h, instead of declaring those functions yourself.
You're right. I will do so. > Should we put the GDK lock statements around those 3 functions? But if > we should, make sure they aren't taken recursively: when called from > Java the GDK lock isn't taken and we must, but when called from the > handle_response callback function, GTK already holds that lock and we > must not. I don't know. I'll try later and let you know. > You've still got some C++ comments: > $ grep '//' b6913179.patch They are comments in Java classes ;-) > Also the patch doesn't even compile from me, fpulling the awt forest > to the latest and trying again... Yesterday I could compile without problems. When I go home later, I check out the last code in the repository and try again. Thanks for your comments and best regards, Costantino
