Hi Peter, Anthony and Damjan, here is a new patch (the 4th one!) with these improvements: * The copyright in GtkFileDialogPeer is now correctly dated. * ANSI C conformity 1: // comments transformed to /* */ * ANSI C conformity 2: Variable declaration always at the beginning of a block * All compiler warnings removed * Error checking (in case of failure, JNU_ThrowInternalError(..) is used) * Multiple selection mode set only in an OPEN action (otherwise Gtk throws a warning when we are saving a file)
As also Peter said, the job is almost done and I hope to see this patch soon in the OpenJDK! Best Regards, Costantino P.S.: About the indentation, I have no idea why it isn't right. I set it in my eclipse workspace according the Anthony's suggestions: Tab policy: Spaces only Indentation size: 4 Tab site: 4 Line width: 80 2010/3/2 Peter Zhelezniakov <[email protected]>: > Hi Costantino, > > Seems almost done! Changes to GTK code seem right thing to do indeed. > > I'd agree that we'd better stay away from any C++-isms such as // and > declaring variables in the middle of a block. This code is built on a > variety of platforms and we don't want to break older ones without a strong > reason. > > Thanks! > -- > Peter | x33066 | location: SPB04 | timezone: GMT+03 >
b6913179.patch
Description: Binary data
