Hi Andrew,

"Client code" is basically anything in 2D, AWT, i18n, beans, a11y, ImageIO, Sound, or Swing. I.e., anything related to GUI/desktop.

In this particular case Omair is changing the SplashScreen code which belongs to AWT, hence the choice of the client repo for integration.

--
best regards,
Anthony

On 2/20/2014 7:30 PM, Andrew Hughes wrote:
----- Original Message -----
Hi Omair,

Should I be pushing this to jdk9/dev ? (Or to jdk9/client?)

If you change client code, then the fix should go to the client repo to
avoid merge conflicts and allow for more manual testing prior to
integrating the changes into the master repo.

Perhaps this would be an appropriate point to clarify what constitutes
'client code'?


--
best regards,
Anthony

On 2/19/2014 8:16 PM, Omair Majid wrote:
* Magnus Ihse Bursie <magnus.ihse.bur...@oracle.com> [2014-02-19 06:59]:
On 2014-02-17 10:16, Erik Joelsson wrote:
At least to me this looks good, but better let Magnus and Andrew
have their say too.

Looks good to me!

Thanks for the reviews, everyone!

I have filed https://bugs.openjdk.java.net/browse/JDK-8035341 to track
the issue. Can someone please point me some docs that explains what I
need to do to to this bug once I have pushed the fix?

Should I be pushing this to jdk9/dev ? (Or to jdk9/client?)

Thanks,
Omair



Thanks,

Reply via email to