They are used for the further coordinates obtaining (on OS X the icon
sizes are not equal for the buttons and the tabbed pane - please see the
screenshot attached to JDK-8151060):
Please see lines 187-189:
187 Component tc = tabbedPane.getTabComponentAt(1);
188 x = tc.getLocationOnScreen().x + tc.getWidth() / 2;
189 c = r.getPixelColor(x, y);
It seems to be a quite reliable way to get the proper x coordinate value
here instead of guessing. (we do not need that for Linux and Win.)
Regards,
Alexander
On 3/9/2016 6:59 PM, Sergey Bylokhov wrote:
Can you please clarify these lines:
117 tabbedPane.addTab("", new JPanel());
118 tabbedPane.setTabComponentAt(1, new JLabel());
On 09.03.16 18:48, Alexander Stepanov wrote:
Hello, Sergey,
Please see the updated version of the test:
http://cr.openjdk.java.net/~avstepan/8150724/webrev.02/
(covers JDK-8151303 as well).
> I suggest to add these lines to the test instead of replace the old
lines
done.
please see "@requires tag" - for now it will stop test run on OS X.
Thanks,
Alexander
On 3/4/2016 7:08 PM, Alexander Stepanov wrote:
The test should be updated to cover the related issue
https://bugs.openjdk.java.net/browse/JDK-8151303
Regards,
Alexander
On 3/4/2016 1:15 PM, Alexander Stepanov wrote:
Hello, Sergey,
We have JLabel(icon) already in the test, and we cannot have both
these cases at the same tab. Moreover, we can in principle use some
other components as an argument of 'setTabComponentAt', but I'm not
sure that these cases have some novelty.
So my suggestion is to can simply return to the old version of the
test (which will fail on OS X) or add it commented with some "TODO:
uncomment / replace after 8151060 fix" instruction in code.
Thanks,
Alexander
On 3/4/2016 1:21 AM, Sergey Bylokhov wrote:
Hi, Alexander.
I suggest to add these lines to the test instead of replace the old
lines. The test will pass after the fix for 8151060.
On 03.03.16 17:45, Alexander Stepanov wrote:
Could you please review the updated version of the test?
http://cr.openjdk.java.net/~avstepan/8150724/webrev.01
Line
106 tabbedPane.addTab("", icon, p);
was replaced with
109 tabbedPane.addTab("", p);
110 tabbedPane.setTabComponentAt(0, new JLabel(icon));
- in such a case the test passes for OS X (as well as for Windows,
Linux).
Probably these changes should be reverted after JDK-8151060 fix.
Thanks,
Alexander
On 3/2/2016 7:15 PM, Alexander Stepanov wrote:
Hello Sergey,
It fails because of
https://bugs.openjdk.java.net/browse/JDK-8151060
(plus we need here some tricky check for resolution by the analogy
with 8150258 because of JDK-8150844).
Thanks,
Alexander
On 2/26/2016 4:25 PM, Sergey Bylokhov wrote:
Hi, Alexander.
The test failed on osx 10.11 + retina. Is it expected?
On 26.02.16 15:53, Alexander Stepanov wrote:
Hello,
Could you please review the following fix
http://cr.openjdk.java.net/~avstepan/8150724/webrev.00/
for
https://bugs.openjdk.java.net/browse/JDK-8150724 ?
Just a single test added.
Thanks,
Alexander
