Hello Alexandr,

Thank you for the explanation. Could you please review the updated test?
http://cr.openjdk.java.net/~avstepan/8150724/webrev.03/

The icon size was reduced.

Thanks,
Alexander


On 3/11/2016 3:14 PM, Alexander Scherbatiy wrote:
On 10/03/16 16:22, Alexander Stepanov wrote:
Hello Alexandr,

Thank you for the comment. Please note that:

1. this hard-coded icon size for the tab is seemingly used only for Mac OS X L&F, please see http://cr.openjdk.java.net/~avstepan/8150724/screenshots/screenshot-1.png (for other L&Fs the tab's size is adjusted to the icon's size. L&Fs are: Metal, Nimbus, CDE/Motif, Mac OS X)
the same for Win. / Ubuntu Linux)

// a loop over the L&Fs available should be added to the initial test code.

2. as it was mentioned earlier, if replace
 tabbedPane.addTab("", icon, p);
with
 tabbedPane.addTab("", p);
 tabbedPane.setTabComponentAt(0, new JLabel(icon));

in the code, then the user can see small but still blue icon:
http://cr.openjdk.java.net/~avstepan/8150724/screenshots/screenshot-2.png

also here:
http://cr.openjdk.java.net/~avstepan/8150724/screenshots/screenshot-3.png it can be seen that the icons for the other components remain hi-res. even when going out of the component borders.

So all the above mentioned causes some feeling of uncoformity :)

Should this tab's icon for Mac OS X L&F be allowed to be so "special"?

Aqua L&F has been designed to make UI components look in the same way as native Mac OS X controls. In this case the tabbed pane icons should look like icons for NSTabView control.

  Thanks,
  Alexandr.


Thanks,
Alexander

On 3/9/2016 7:10 PM, Alexander Scherbatiy wrote:


On 03/03/16 18:45, Alexander Stepanov wrote:
Could you please review the updated version of the test?
http://cr.openjdk.java.net/~avstepan/8150724/webrev.01

Line
 106         tabbedPane.addTab("", icon, p);
was replaced with
 109         tabbedPane.addTab("", p);
 110         tabbedPane.setTabComponentAt(0, new JLabel(icon));

- in such a case the test passes for OS X (as well as for Windows, Linux).
Probably these changes should be reverted after JDK-8151060 fix.

There is no issue because the ImageIcon with base image size 35 and high-resolution image size 70 is requested to be painted into region 32x32 for JTabbedPane icon. In this case the base image has enough quality to be painted in this region.

To check that MultiResolutionImage is properly painted for JTabbedIcon it is possible to use BaseMultiResolutionImage with images with sizes 16x16 and 32x32.

Thanks,
Alexandr.


Thanks,
Alexander

On 3/2/2016 7:15 PM, Alexander Stepanov wrote:
Hello Sergey,

It fails because of
https://bugs.openjdk.java.net/browse/JDK-8151060

(plus we need here some tricky check for resolution by the analogy with 8150258 because of JDK-8150844).

Thanks,
Alexander

On 2/26/2016 4:25 PM, Sergey Bylokhov wrote:
Hi, Alexander.
The test failed on osx 10.11 + retina. Is it expected?

On 26.02.16 15:53, Alexander Stepanov wrote:
Hello,

Could you please review the following fix
http://cr.openjdk.java.net/~avstepan/8150724/webrev.00/
for
https://bugs.openjdk.java.net/browse/JDK-8150724 ?

Just a single test added.

Thanks,
Alexander








Reply via email to