Hi Dmitry,

Apple uses macOS to refer to its operating system, so should we also use it instead of former OS X?

For HTML version, I would suggest using the following markup <kbd><kbd>Ctrl</kbd> +<kbd>F1</kbd></kbd> for the keyboard shortcut. [1]

I think using <pre><code> elements for instructions on how to disable the shortcut is incorrect. In fact, it does not require any special markup.


What about this text?
<p>Some client UI tests devoted to tooltips may fail on macOS platform. The tests use <kbd><kbd>Ctrl</kbd> +<kbd>F1</kbd></kbd> key sequence to show/hide a tooltip. However, this key combination is reserved by the operating system. To run these tests correctly, the default global shortcut should be disabled: choose Apple menu &gt; System Preferences, click Keyboard, then click Shortcuts; deselect "Turn keyboard access on/of" property.<p>

I copied the way Apple uses in its documentation to refer to commands.

On 25/10/2019 11:27, Dmitry Markov wrote:
Hello,

Could you review the fix for jdk14, please?

bug: https://bugs.openjdk.java.net/browse/JDK-8232880
webrev: http://cr.openjdk.java.net/~dmarkov/8232880/webrev.00/

Some Client UI tests use the following key sequence to show/hide tooltip message: “CTRL” + “F1". However this key combination is reserved by operating system on OS X platform. As a results the tests fail.
Test documentation should be updated with some notes regarding this.

Thanks,
Dmitry


[1] https://www.w3.org/TR/html52/textlevel-semantics.html#the-kbd-element

--
Regards,
Alexey

Reply via email to