Hi Dmitry,
437 …by the operating system. …
I'd modify the following text a bit:
To run the test correctly, the default global key shortcut should be
disabled. Follow the steps above, and then deselect "Turn keyboard
access on or off" property which is responsible for `CTRL + F1` combination.
Does it sound clearer?
I'd not use backticks on the "Turn keyboard access on or off" because
it's not something user is typing, nor is it a piece of code. Is the
word “property” correct? Does “shortcut” or “option” fit better?
I'd recommend adding quotes around the option to look for:
448 in the right-side pane look for "Turn off Windows key hotkeys" and
double click on it;
Consider adding an empty line before this line
450 Note: restart is required to make the settings take effect.
to make it a separate paragraph in HTML.
Regards,
Alexey
On 31/10/2019 10:56, Dmitry Markov wrote:
Hi Alexey,
I have updated the fix based on your recommendation. The new version
is located at: http://cr.openjdk.java.net/~dmarkov/8232880/webrev.02/
Also please find my answers inline.
Thanks,
Dmitry
On 29 Oct 2019, at 19:29, Alexey Ivanov <alexey.iva...@oracle.com
<mailto:alexey.iva...@oracle.com>> wrote:
Hi Dmitry,
Shall we drop hyphen in the header: “Client UI Tests”?
I think there should be no definite article in this sentence: “use
-the- key sequences”.
“…Turn off Windowss key hotkeys…”, there's an extra ‘s’ in Windows.
”Note: restart is required to make the settings take effect.”
Just to confirm: is signing out and signing in not enough?
According to Microsoft site: restart is required but I guess signing
out/in should work too. Unfortunately I do not have Windows on hand to
check it out.
I'd use backticks for gpedit markup: “Type `gpedit` in the Search…”
Does it make sense to move the example into macOS section? Then the
steps to disable the shortcut can be reduced to the required option
only. The steps themselves should not be listed as code, i.e. no
backticks.
(For my understanding, "Turn keyboard access on or off" turns off
only one specific shortcut, i.e. Ctrl+F1?)
Yes, that’s right. I have added clarification to the doc.
Regards,
Alexey
