Hi Alexey, I have updated the fix based on your recommendation. The new version is located at: http://cr.openjdk.java.net/~dmarkov/8232880/webrev.02/ <http://cr.openjdk.java.net/~dmarkov/8232880/webrev.02/> Also please find my answers inline.
Thanks, Dmitry > On 29 Oct 2019, at 19:29, Alexey Ivanov <alexey.iva...@oracle.com> wrote: > > Hi Dmitry, > > Shall we drop hyphen in the header: “Client UI Tests”? > > I think there should be no definite article in this sentence: “use -the- key > sequences”. > > “…Turn off Windowss key hotkeys…”, there's an extra ‘s’ in Windows. > > ”Note: restart is required to make the settings take effect.” > Just to confirm: is signing out and signing in not enough? According to Microsoft site: restart is required but I guess signing out/in should work too. Unfortunately I do not have Windows on hand to check it out. > > I'd use backticks for gpedit markup: “Type `gpedit` in the Search…” > > > Does it make sense to move the example into macOS section? Then the steps to > disable the shortcut can be reduced to the required option only. The steps > themselves should not be listed as code, i.e. no backticks. > > (For my understanding, "Turn keyboard access on or off" turns off only one > specific shortcut, i.e. Ctrl+F1?) Yes, that’s right. I have added clarification to the doc. > > > Regards, > Alexey > > On 28/10/2019 17:23, Dmitry Markov wrote: >> Hi Alexey, Erik, Sergey, >> Thank you for your feedback. I have updated the fix based on your >> suggestions: http://cr.openjdk.java.net/~dmarkov/8232880/webrev.01/ >> <http://cr.openjdk.java.net/~dmarkov/8232880/webrev.01/> >> Can you take a look, please? >> >> Thanks, >> Dmitry >> >>> On 26 Oct 2019, at 00:55, Sergey Bylokhov <sergey.bylok...@oracle.com >>> <mailto:sergey.bylok...@oracle.com>> wrote: >>> >>> Hi, Dmitry. >>> >>> I suggest to make this block more generic, and describe the "### Client UI >>> - Tests". >>> It would be useful to mention that the tests in this category use different >>> key combinations, >>> which might be registered as a system shortcuts, and it could cause a test >>> failure. It is suggested >>> to disable these shortcuts: >>> - macOS config location..... >>> - Linux config location..... >>> - On window some other application may have global shortcuts.... >>> >>> As an example of such issue you can provide CTRL+F1 which is used.... >>> >>> >>> On 10/25/19 3:27 am, Dmitry Markov wrote: >>>> Hello, >>>> Could you review the fix for jdk14, please? >>>> bug: https://bugs.openjdk.java.net/browse/JDK-8232880 >>>> <https://bugs.openjdk.java.net/browse/JDK-8232880> >>>> <https://bugs.openjdk.java.net/browse/JDK-8232880 >>>> <https://bugs.openjdk.java.net/browse/JDK-8232880>> >>>> webrev: http://cr.openjdk.java.net/~dmarkov/8232880/webrev.00/ >>>> <http://cr.openjdk.java.net/~dmarkov/8232880/webrev.00/> >>>> <http://cr.openjdk.java.net/~dmarkov/8232880/webrev.00/ >>>> <http://cr.openjdk.java.net/~dmarkov/8232880/webrev.00/>> >>>> Some Client UI tests use the following key sequence to show/hide tooltip >>>> message: “CTRL” + “F1". However this key combination is reserved by >>>> operating system on OS X platform. As a results the tests fail. >>>> Test documentation should be updated with some notes regarding this. >>>> Thanks, >>>> Dmitry >>> >>> >>> -- >>> Best regards, Sergey. >> >
