Hey,
I've been working on this problem and ran into some issues and would
like to get your comments before committing a fix. The
RepositoryListener.findServicesInDirectory() scans the "services"
directory and tries to deploy service modules (.jar or .aar files)
using ServiceDeployer. But also, when it files files with other
extensions it tries to deploy them too using a Deployer registered for
the given extension. For example, if you have the following deployer
entry in the axis2.xml:
<deployer extension=".svc" directory="widgets"
class="org.apache.axis2.deployment.deployers.CustomDeployer"/>
The CustomDeployer will be used to deploy files with .svc extension in
the "widgets" directory AND the "services" directory. That's a bit
weird, IMHO.
So, what I'm proposing is to remove the entire 'else' statement at
line 303 on RepositoryListener.findServicesInDirectory() so that only
service modules (.jar or .aar files) can be deployed from within the
services directory. This solution might break some existing
deployments where people put non-service module files under the
services directory but that can be easily fixed by either moving the
files to the right directory or by adding another deployer entry in
axis2.xml for the services directory. For example:
<deployer extension=".svc" directory="widgets"
class="org.apache.axis2.deployment.deployers.CustomDeployer"/>
<deployer extension=".svc" directory="services"
class="org.apache.axis2.deployment.deployers.CustomDeployer"/>
Thoughts?
Jarek
On Tue, Oct 28, 2008 at 5:20 PM, Jarek Gawor <[EMAIL PROTECTED]> wrote:
> Hi,
>
> Does anyone have comments on
> https://issues.apache.org/jira/browse/AXIS2-4101? In general, I would
> like to know if we should allow for multiple deployers to be
> registered for the same file extension (for any directory). Right now,
> only one is assumed and that causes problems.
>
> Thanks,
> Jarek
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
