I agree with changing the transport dependencies to test scope but in general I'm a little concerned about the circular dependency between axis2 and axis2-transport modules. Because of that circular dependency I think we have to release axis2 and axis2-transport at the same time (at least the base, local, tcp and http transport modules) and I thought the idea behind splitting transport code from Axis2 was to release the transport modules independently from Axis2.
Jarek On Wed, Jan 14, 2009 at 4:48 AM, Andreas Veithen <[email protected]> wrote: > Asankha, > > I agree with your changes and I share your point of view that we > should reduce dependencies an the transports to a minimum. From what > I've seen, the problem is simply that some modules depending on > addressing, clustering and/or saaj (the ones you changed) implicitly > rely on the fact that they depend on the transports. Probably it is > just a matter of adding them as dependencies in scope test in the > right places (jaxws, metadata, etc.). I would have corrected that > myself yesterday if it were not for the fact that it takes 50 min to > build the whole Axis2 project :-) > > Andreas > > On Wed, Jan 14, 2009 at 04:38, Asankha C. Perera <[email protected]> wrote: >> Hi Andreas >>> >>> I had to revert this change (and the previous one) because they cause >>> the Axis2 build to fail (not in the modules you changed, but in >>> modules depending on those, e.g. jaxws and metadata). >>> >> >> Thanks.. and I am sorry I couldn't run the full build of Axis2.. but I did >> test the modules I changed, and still think that they should not make the >> local and tcp transports required dependencies unless they are required at >> runtime >> >> Having unwanted dependencies just makes it difficult for these to be used by >> other projects.. I will try to fix this in Axis2 again, or exclude them from >> the Synapse build which will just make its pom larger :( >> >> thanks >> asankha >>> >>> On Tue, Jan 13, 2009 at 19:03, <[email protected]> wrote: >>> >>>> >>>> Author: asankha >>>> Date: Tue Jan 13 10:02:54 2009 >>>> New Revision: 734201 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=734201&view=rev >>>> Log: >>>> make transport dependencies valid only for the testing scope in maven >>>> >> >> -- >> Asankha C. Perera >> http://adroitlogic.org >> >> http://esbmagic.blogspot.com >> >> >
