An unicast batman-adv packet cannot be transmitted to a multicast or zero
address. So reject incoming packets which still have these classes of
addresses as destination mac address.

Signed-off-by: Sven Eckelmann <[email protected]>
---
 net/batman-adv/routing.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/net/batman-adv/routing.c b/net/batman-adv/routing.c
index b648caf..44e1e80 100644
--- a/net/batman-adv/routing.c
+++ b/net/batman-adv/routing.c
@@ -353,8 +353,8 @@ int batadv_recv_icmp_packet(struct sk_buff *skb,
 
        ethhdr = eth_hdr(skb);
 
-       /* packet with unicast indication but broadcast recipient */
-       if (is_broadcast_ether_addr(ethhdr->h_dest))
+       /* packet with unicast indication but non-unicast recipient */
+       if (!is_valid_ether_addr(ethhdr->h_dest))
                goto out;
 
        /* packet with invalid sender address */
@@ -445,8 +445,8 @@ static int batadv_check_unicast_packet(struct batadv_priv 
*bat_priv,
 
        ethhdr = eth_hdr(skb);
 
-       /* packet with unicast indication but broadcast recipient */
-       if (is_broadcast_ether_addr(ethhdr->h_dest))
+       /* packet with unicast indication but non-unicast recipient */
+       if (!is_valid_ether_addr(ethhdr->h_dest))
                return -EBADR;
 
        /* packet with invalid sender address */
-- 
2.8.1

Reply via email to