On Samstag, 6. August 2016 06:42:44 CEST Linus Lüssing wrote: > On Mon, Jul 18, 2016 at 12:15:40AM +0200, Sven Eckelmann wrote: > > The routing checks are validating the sender mac address. They reject every > > sender mac address which is a broadcast. But they also have to reject > > zero-mac address and multicast mac addresses. > > Initially I was a little shocked because there are legitimate > cases for zero-source MAC addresesses. But then I saw in the code > that you are talking about source MAC address of the outter > batman-adv frame :). Maybe that could be clarified in the commit > message?
Ah yes, you are right. This should be described better in the commit
message.
> For batadv_check_management_packet(), agreed, I guess much of the
> protocol does rely on valid source addresses.
Yes, think so too.
> For data packets, I'm not quite sure, though. Could be interesting
> to not restrict that now to still allow enhancements regarding
> privacy, I think. And zero-source MAC addresses shouldn't harm
> anything in the case of data packets, should they?
So you would prefer here that is_broadcast_ether_addr is replaced
for bcast and ucast packets with is_multicast_ether_addr? Same for
patch 2, right?
Kind regards,
Sven
signature.asc
Description: This is a digitally signed message part.
