On Mon, Sep 27, 2010 at 03:23:01PM +0100, Toby Gray wrote: > Yes. Seems entirely reasonable. I'll add a new exception deriving from > Barry::Error for zero length reads. Do you think it should be a more > general short packet exception and also capture the read being less than > sizeof(pack->socket) case?
Hi Toby, Thanks... that sounds good. You don't need to include the short packet condition, as that is already handled by the BadSize exception, in protocol.cc's CheckSize() function. > My initial feeling was to treat both cases the same, as there's clearly > something we don't understand going on, so it's probably best to get a > bug reporting that Barry doesn't work than to carry on. However I'd be > happy to continue the current behaviour of just skipping packets of 1 > byte length. Maybe I missed it, but where do we skip packets of 1 byte in length? If it is something special in m_raw_channel.cc, in order to make it work, I'm ok with skipping such packets in that context alone. But I didn't think we had such a case in the general library. - Chris ------------------------------------------------------------------------------ Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev _______________________________________________ Barry-devel mailing list Barry-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/barry-devel
