On 30/09/2010 23:37, Chris Frey wrote: > On Wed, Sep 29, 2010 at 02:04:36PM +0100, Toby Gray wrote: >> Hi Chris, > Thanks for these patches. :-) I've been slower to reply lately as I've > been under the weather. That's ok, I hope you've recovered. >> I've made the changes in my github branch >> git://github.com/tobygray/barry.git in commit c7685942140b123bf110. Is >> that the sort of change you were thinking of? > This is better yes, and I've merged it. > > My main concern (and this might need another change) is that this fix > only works if the router is used. If threaded reads are not enabled, > then 0 size packets will behave as before. > > If this matters, we'll need an exception at a lower level... maybe > something like Usb::NoData or something. I did consider add it as a subclass of Usb::Error but decided not to as it's more of a protocol error rather than an error with the Usb. On the other hand the only situation we see it in is when there has been a Usb error, so it is really a Usb error.
I'm happy to switch it over to being a Usb::Error and to make SocketZero::RawReceive check for reads without the socket header. Likewise the Intro reading code in probe.cc and IpModem will need updating to check for small responses as I don't think Usb::Device::BulkRead is the correct place for this check as it's a protocol detail. >> I've also got a couple of other changes on my branch, >> d7a5c884f47ed96a7795 and b72b7c5cd2bf5d94756c which fix build issues I >> was having with building Barry on a PC-BSD machine. > Thanks! Merged these as well, with slight changes. Excellent, thanks for making those updates. Regards, Toby ------------------------------------------------------------------------------ Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev _______________________________________________ Barry-devel mailing list Barry-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/barry-devel
