----- Robert Widhopf-Fenk (2007-05-30) wrote:----- [...] >> Does the following patch looks good: >> >> >> --- bbdb.el 30 May 2007 00:05:04 +0100 1.246 >> +++ bbdb.el 30 May 2007 00:28:34 +0100 >> @@ -1873,8 +1873,8 @@ >> (if bbdb-multiple-buffers (bbdb-pop-up-bbdb-buffer)) >> >> (save-excursion >> - (set-buffer bbdb-buffer-name) >> - >> + (set-buffer (get-buffer-create bbdb-buffer-name)) > > This line does look good, but > >> + (let ((inhibit-read-only t)) (erase-buffer)) > > this one not. Why do you want to erase the buffer, it > should not be necessary.
Without this line, there is another bug. It can be reproduced this way. 1. M-x bbdb 2. type something that will match a few records 3. Change to a mailer, I use message mode, and do a name completion in the 'To' field. 4. Go back to the *BBDB* buffer, you will see duplicates. When you edit the name of the duplicates, it will show the value of what you type in the mailer. The second line I added is trying to mimic 'with-output-to-temp-buffer': ,----[ with-output-to-temp-buffer ] | The buffer is cleared out initially, and marked as unmodified when done. `---- > I have committed a sightly different bugfix where the buffer is > created in bbdb-pop-up-bbdb-buffer where I IMHO caused the problem. It has the same problem as described above. > While I was not able to reproduce it here (I always have a BBDB buffer > around :), I hope it fixes it for you. Since the "*BBDB*" is not associated with any file, you can kill it and start a bbdb search to see the bug. > Thanks for reporting this, > Robert Best, -- Leo <sdl.web AT gmail.com> (GPG Key: 9283AA3F) ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/