On Wed Dec 28 2011 Sam Steingold wrote: > here is the fix: > > diff --git a/lisp/bbdb-mua.el b/lisp/bbdb-mua.el > index e0059a1..2d515ab 100644 > --- a/lisp/bbdb-mua.el > +++ b/lisp/bbdb-mua.el > @@ -657,7 +657,8 @@ For interactive calls, see function > `bbdb-mua-update-interactive-p'." > (interactive (list nil (bbdb-mua-update-interactive-p))) > (let (records) > (bbdb-mua-wrapper > - (setq records (bbdb-mua-update-records header-class update-p))) > + (setq records (bbdb-mua-update-records > + header-class (or update-p bbdb-mua-auto-update-p)))) > (if records (bbdb-display-records-internal records)) > records))
I am confused: What is this patch supposed to fix? Where / how is bbdb-mua-display-records called such that it needs to use the variable bbdb-mua-auto-update-p? The command bbdb-mua-display-records is intended for interactive use, whereas the variable bbdb-mua-auto-update-p and the function bbdb-mua-auto-update are intended for noninteractive use. If the command bbdb-mua-display-records is used in some noninteractive context, it appears to me it would be the cleaner (more flexible) solution if the caller of bbdb-mua-display-records sets its arg UPDATE-P appropriately. But anyway, such noninteractive use should call bbdb-mua-auto-update. Roland ------------------------------------------------------------------------------ Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex infrastructure or vast IT resources to deliver seamless, secure access to virtual desktops. With this all-in-one solution, easily deploy virtual desktops for less than the cost of PCs and save 60% on VDI infrastructure costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox _______________________________________________ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
